[gnome-shell] appMenu: Only show Open Windows, if there are at least 2 windows
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] appMenu: Only show Open Windows, if there are at least 2 windows
- Date: Thu, 29 Apr 2021 14:36:21 +0000 (UTC)
commit fd0da9606fd2481bf67cb488f86d73ab388ff947
Author: Leleat <atule pm me>
Date: Thu Apr 29 01:09:50 2021 +0200
appMenu: Only show Open Windows, if there are at least 2 windows
It doesn't make sense to show the 'Open Windows' in the app menu,
if the app only has 1 open window to switch between. Hide the
window section in that case.
Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4199.
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1827>
js/ui/panel.js | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/panel.js b/js/ui/panel.js
index cba32416a2..1474886ef0 100644
--- a/js/ui/panel.js
+++ b/js/ui/panel.js
@@ -30,7 +30,8 @@ class AppMenu extends PopupMenu.PopupMenu {
this._windowsChangedId = 0;
/* Translators: This is the heading of a list of open windows */
- this.addMenuItem(new PopupMenu.PopupSeparatorMenuItem(_("Open Windows")));
+ this._openWindowsHeader = new PopupMenu.PopupSeparatorMenuItem(_('Open Windows'));
+ this.addMenuItem(this._openWindowsHeader);
this._windowSection = new PopupMenu.PopupMenuSection();
this.addMenuItem(this._windowSection);
@@ -118,11 +119,17 @@ class AppMenu extends PopupMenu.PopupMenu {
_updateWindowsSection() {
this._windowSection.removeAll();
+ this._openWindowsHeader.hide();
if (!this._app)
return;
let windows = this._app.get_windows();
+ if (windows.length < 2)
+ return;
+
+ this._openWindowsHeader.show();
+
windows.forEach(window => {
let title = window.title || this._app.get_name();
let item = this._windowSection.addAction(title, event => {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]