[gnome-shell/benzea/fix-password-login-after-bg-failure: 4/5] gdm: Only disconnect verification signals when not going to retry




commit 9157969ab83526a8a40e624d044d857459793768
Author: Ray Strode <rstrode redhat com>
Date:   Wed Apr 28 10:44:56 2021 -0400

    gdm: Only disconnect verification signals when not going to retry
    
    At the moment a failure in a background service can lead to the
    various verification signals getting disconnected, even though
    we still need them for a foreground service.
    
    This commit changes the code to only disconnect when we've run
    out of tries.

 js/gdm/util.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/gdm/util.js b/js/gdm/util.js
index cb70c285f5..ecaf09b6a8 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -690,13 +690,13 @@ var ShellUserVerifier = class {
         // the dialog
         // Otherwise, when in login mode we allow ALLOWED_FAILURES attempts.
         // After that, we go back to the welcome screen.
-        this._disconnectSignals();
-
         this._filterServiceMessages(serviceName, MessageType.ERROR);
 
         const doneTrying = !shouldRetry || !this._canRetry();
 
         if (doneTrying) {
+            this._disconnectSignals();
+
             // eslint-disable-next-line no-lonely-if
             if (!this.hasPendingMessages) {
                 this._cancelAndReset();


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]