[vala/0.52] codegen: Don't use G_GNUC_INTERNAL on implicit type specific fields



commit 30baa93f1a7f1b89a55a9ec2cf05d0e4ae3f5821
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Tue Apr 27 10:24:55 2021 +0200

    codegen: Don't use G_GNUC_INTERNAL on implicit type specific fields
    
    The actual field was never handled that way, so don't apply it at all
    when --hide-internal is passed.
    
    Introduced by 970f58989a2863faca11e30fdbcf4da1273a6acd which claimed to
    apply it to methods only.
    
    Fixes https://gitlab.gnome.org/GNOME/vala/issues/1178

 codegen/valaccodebasemodule.vala | 8 --------
 1 file changed, 8 deletions(-)
---
diff --git a/codegen/valaccodebasemodule.vala b/codegen/valaccodebasemodule.vala
index 714a3c289..dda0fb22c 100644
--- a/codegen/valaccodebasemodule.vala
+++ b/codegen/valaccodebasemodule.vala
@@ -1163,8 +1163,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
 
                        if (f.is_private_symbol ()) {
                                flock.modifiers = CCodeModifiers.STATIC;
-                       } else if (context.hide_internal && f.is_internal_symbol ()) {
-                               flock.modifiers = CCodeModifiers.INTERNAL;
                        } else {
                                flock.modifiers = CCodeModifiers.EXTERN;
                        }
@@ -1182,8 +1180,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                        cdecl.add_declarator (new CCodeVariableDeclarator 
(get_variable_array_length_cname (f, dim)));
                                        if (f.is_private_symbol ()) {
                                                cdecl.modifiers = CCodeModifiers.STATIC;
-                                       } else if (context.hide_internal && f.is_internal_symbol ()) {
-                                               cdecl.modifiers = CCodeModifiers.INTERNAL;
                                        } else {
                                                cdecl.modifiers = CCodeModifiers.EXTERN;
                                        }
@@ -1199,8 +1195,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                cdecl.add_declarator (new CCodeVariableDeclarator 
(get_ccode_delegate_target_name (f)));
                                if (f.is_private_symbol ()) {
                                        cdecl.modifiers = CCodeModifiers.STATIC;
-                               } else if (context.hide_internal && f.is_internal_symbol ()) {
-                                       cdecl.modifiers = CCodeModifiers.INTERNAL;
                                } else {
                                        cdecl.modifiers = CCodeModifiers.EXTERN;
                                }
@@ -1211,8 +1205,6 @@ public abstract class Vala.CCodeBaseModule : CodeGenerator {
                                        cdecl.add_declarator (new CCodeVariableDeclarator 
(get_ccode_delegate_target_destroy_notify_name (f)));
                                        if (f.is_private_symbol ()) {
                                                cdecl.modifiers = CCodeModifiers.STATIC;
-                                       } else if (context.hide_internal && f.is_internal_symbol ()) {
-                                               cdecl.modifiers = CCodeModifiers.INTERNAL;
                                        } else {
                                                cdecl.modifiers = CCodeModifiers.EXTERN;
                                        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]