[gnome-builder] omni-gutter: Fix diagnostic severity check
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] omni-gutter: Fix diagnostic severity check
- Date: Wed, 21 Apr 2021 19:21:55 +0000 (UTC)
commit 15d2448c1fba250f63969ba9270ad78003138db4
Author: James Westman <james jwestman net>
Date: Wed Apr 21 12:29:18 2021 -0500
omni-gutter: Fix diagnostic severity check
The gutter renderer was treating IdeDiagnosticSeverity as a bitflag,
when it is a regular enum. This happened to work with the current
values, but when new values are added it will break.
src/plugins/omni-gutter/gbp-omni-gutter-renderer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/src/plugins/omni-gutter/gbp-omni-gutter-renderer.c
b/src/plugins/omni-gutter/gbp-omni-gutter-renderer.c
index 5bb5d41a3..17683ab21 100644
--- a/src/plugins/omni-gutter/gbp-omni-gutter-renderer.c
+++ b/src/plugins/omni-gutter/gbp-omni-gutter-renderer.c
@@ -541,9 +541,9 @@ populate_diagnostics_cb (guint line,
g_assert (line <= state->end_line);
info = &g_array_index (state->lines, LineInfo, line - state->begin_line);
- info->is_warning |= !!(severity & (IDE_DIAGNOSTIC_WARNING | IDE_DIAGNOSTIC_DEPRECATED));
- info->is_error |= !!(severity & (IDE_DIAGNOSTIC_ERROR | IDE_DIAGNOSTIC_FATAL));
- info->is_note |= !!(severity & IDE_DIAGNOSTIC_NOTE);
+ info->is_warning |= severity == IDE_DIAGNOSTIC_WARNING || severity == IDE_DIAGNOSTIC_DEPRECATED;
+ info->is_error |= severity == IDE_DIAGNOSTIC_ERROR || severity == IDE_DIAGNOSTIC_FATAL;
+ info->is_note |= severity == IDE_DIAGNOSTIC_NOTE;
}
static void
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]