[gnome-todo/gbsneto/remove-plugin-dialog] Remove plugins dialog

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit ab0541a22f73a5b8cadd89a0084021911d6239ef
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue Apr 20 21:51:07 2021 -0300

    Remove plugins dialog
    
    Plugins have evolved over time, and for the future, they
    are hooking points to the application. As they stand now,
    they aren't toggable features, but rather implementation
    details of them.
    
    In fact, in the future, the fact that they are plugins is
    going to be transparent: it's merely a design choice on how
    to organize feature inside To Do.
    
    Remove the plugins dialog, and all related components. No
    plugins were harmed while creating this commit.
    
    Closes https://gitlab.gnome.org/GNOME/gnome-todo/-/issues/329

 doc/reference/meson.build        |   2 -
 po/POTFILES.in                   |   2 -
 src/gui/gtd-application.c        |  22 ---
 src/gui/gtd-plugin-dialog-row.c  | 298 ---------------------------------------
 src/gui/gtd-plugin-dialog-row.h  |  47 ------
 src/gui/gtd-plugin-dialog-row.ui |  99 -------------
 src/gui/gtd-plugin-dialog.c      | 247 --------------------------------
 src/gui/gtd-plugin-dialog.h      |  36 -----
 src/gui/gtd-plugin-dialog.ui     | 103 --------------
 src/gui/gtd-window.ui            |  10 --
 src/gui/gui.gresource.xml        |   2 -
 src/meson.build                  |   2 -
 12 files changed, 870 deletions(-)
---
diff --git a/doc/reference/meson.build b/doc/reference/meson.build
index 5c80ddfe..d5e4ca35 100644
--- a/doc/reference/meson.build
+++ b/doc/reference/meson.build
@@ -16,8 +16,6 @@ private_headers = [
   'gtd-list-selector-panel.h',
   'gtd-manager-protected.h',
   'gtd-notification-widget.h',
-  'gtd-plugin-dialog.h',
-  'gtd-plugin-dialog-row.h',
   'gtd-plugin-manager.h',
   'gtd-provider-dialog.h',
   'gtd-provider-popover.h',
diff --git a/po/POTFILES.in b/po/POTFILES.in
index 3d9d3d3f..fbe6adb3 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -10,8 +10,6 @@ src/gui/gtd-initial-setup-window.ui
 src/gui/gtd-new-task-row.c
 src/gui/gtd-new-task-row.ui
 src/gui/gtd-omni-area.ui
-src/gui/gtd-plugin-dialog-row.c
-src/gui/gtd-plugin-dialog.ui
 src/gui/gtd-provider-popover.c
 src/gui/gtd-provider-popover.ui
 src/gui/gtd-provider-row.ui
diff --git a/src/gui/gtd-application.c b/src/gui/gtd-application.c
index 20c2aa18..85aed88b 100644
--- a/src/gui/gtd-application.c
+++ b/src/gui/gtd-application.c
@@ -26,7 +26,6 @@
 #include "gtd-log.h"
 #include "gtd-manager.h"
 #include "gtd-manager-protected.h"
-#include "gtd-plugin-dialog.h"
 #include "gtd-theme-manager.h"
 #include "gtd-vcs.h"
 #include "gtd-window.h"
@@ -45,7 +44,6 @@ struct _GtdApplication
   GtdThemeManager       *theme_manager;
 
   GtkWindow             *window;
-  GtkWidget             *plugin_dialog;
   GtkWidget             *initial_setup;
 };
 
@@ -57,10 +55,6 @@ static void           gtd_application_start_client                (GSimpleAction
                                                                    GVariant             *parameter,
                                                                    gpointer              user_data);
 
-static void           gtd_application_show_extensions             (GSimpleAction        *simple,
-                                                                   GVariant             *parameter,
-                                                                   gpointer              user_data);
-
 static void           gtd_application_show_about                  (GSimpleAction        *simple,
                                                                    GVariant             *parameter,
                                                                    gpointer              user_data);
@@ -80,7 +74,6 @@ static GOptionEntry cmd_options[] = {
 static const GActionEntry gtd_application_entries[] = {
   { "activate", gtd_application_activate_action },
   { "start-client", gtd_application_start_client },
-  { "show-extensions",  gtd_application_show_extensions },
   { "about",  gtd_application_show_about },
   { "quit",   gtd_application_quit }
 };
@@ -104,16 +97,6 @@ gtd_application_start_client (GSimpleAction *simple,
   g_debug ("Starting up client");
 }
 
-static void
-gtd_application_show_extensions (GSimpleAction *simple,
-                                 GVariant      *parameter,
-                                 gpointer       user_data)
-{
-  GtdApplication *self = GTD_APPLICATION (user_data);
-
-  gtk_widget_show (self->plugin_dialog);
-}
-
 static void
 gtd_application_show_about (GSimpleAction *simple,
                             GVariant      *parameter,
@@ -268,11 +251,6 @@ gtd_application_startup (GApplication *application)
   gtk_window_set_default_icon_name (APPLICATION_ID);
   self->window = GTK_WINDOW (gtd_window_new (self));
 
-  /* plugin dialog */
-  self->plugin_dialog = gtd_plugin_dialog_new ();
-
-  gtk_window_set_transient_for (GTK_WINDOW (self->plugin_dialog), GTK_WINDOW (self->window));
-
   /* Load the plugins */
   gtd_manager_load_plugins (gtd_manager_get_default ());
 
diff --git a/src/gui/gtd-window.ui b/src/gui/gtd-window.ui
index 9ff84e69..d45f6198 100644
--- a/src/gui/gtd-window.ui
+++ b/src/gui/gtd-window.ui
@@ -136,16 +136,6 @@
   </object>
 
   <menu id="app-menu">
-
-    <!--
-    <section>
-      <item>
-        <attribute name="label" translatable="yes">Extensions</attribute>
-        <attribute name="action">app.show-extensions</attribute>
-      </item>
-    </section>
-    -->
-
     <section>
       <item>
         <attribute name="label" translatable="yes">_About To Do</attribute>
diff --git a/src/gui/gui.gresource.xml b/src/gui/gui.gresource.xml
index 1beec797..6857c452 100644
--- a/src/gui/gui.gresource.xml
+++ b/src/gui/gui.gresource.xml
@@ -8,8 +8,6 @@
     <file compressed="true" preprocess="xml-stripblanks">gtd-new-task-row.ui</file>
     <file compressed="true" preprocess="xml-stripblanks">gtd-notification-widget.ui</file>
     <file compressed="true" preprocess="xml-stripblanks">gtd-omni-area.ui</file>
-    <file compressed="true" preprocess="xml-stripblanks">gtd-plugin-dialog.ui</file>
-    <file compressed="true" preprocess="xml-stripblanks">gtd-plugin-dialog-row.ui</file>
     <file compressed="true" preprocess="xml-stripblanks">gtd-provider-popover.ui</file>
     <file compressed="true" preprocess="xml-stripblanks">gtd-provider-row.ui</file>
     <file compressed="true" preprocess="xml-stripblanks">gtd-provider-selector.ui</file>
diff --git a/src/meson.build b/src/meson.build
index bea40f5b..27440315 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -152,8 +152,6 @@ sources += files(
   'gui/gtd-max-size-layout.c',
   'gui/gtd-omni-area.c',
   'gui/gtd-omni-area-addin.c',
-  'gui/gtd-plugin-dialog.c',
-  'gui/gtd-plugin-dialog-row.c',
   'gui/gtd-theme-manager.c',
   'gui/gtd-widget.c',
   'gui/gtd-window.c',