[gnome-software: 3/15] gs-app-tile: Simplify constructors of derived classes
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software: 3/15] gs-app-tile: Simplify constructors of derived classes
- Date: Tue, 20 Apr 2021 16:08:57 +0000 (UTC)
commit 3fbf273a7f0eaf0d5b7462f33949c7b9a8bfe125
Author: Philip Withnall <pwithnall endlessos org>
Date: Tue Apr 20 13:50:15 2021 +0100
gs-app-tile: Simplify constructors of derived classes
They can specify the `app` property at construction time now. This
introduces no functional changes.
Signed-off-by: Philip Withnall <pwithnall endlessos org>
src/gs-feature-tile.c | 7 ++-----
src/gs-popular-tile.c | 7 +++----
src/gs-summary-tile.c | 8 ++++----
3 files changed, 9 insertions(+), 13 deletions(-)
---
diff --git a/src/gs-feature-tile.c b/src/gs-feature-tile.c
index 9eaef4c33..1c85083eb 100644
--- a/src/gs-feature-tile.c
+++ b/src/gs-feature-tile.c
@@ -466,11 +466,8 @@ gs_feature_tile_class_init (GsFeatureTileClass *klass)
GtkWidget *
gs_feature_tile_new (GsApp *app)
{
- GsFeatureTile *tile;
- tile = g_object_new (GS_TYPE_FEATURE_TILE,
+ return g_object_new (GS_TYPE_FEATURE_TILE,
"vexpand", FALSE,
+ "app", app,
NULL);
- if (app != NULL)
- gs_app_tile_set_app (GS_APP_TILE (tile), app);
- return GTK_WIDGET (tile);
}
diff --git a/src/gs-popular-tile.c b/src/gs-popular-tile.c
index fe1e7a1af..3bec21d43 100644
--- a/src/gs-popular-tile.c
+++ b/src/gs-popular-tile.c
@@ -128,8 +128,7 @@ gs_popular_tile_class_init (GsPopularTileClass *klass)
GtkWidget *
gs_popular_tile_new (GsApp *app)
{
- GsPopularTile *tile = g_object_new (GS_TYPE_POPULAR_TILE, NULL);
- if (app != NULL)
- gs_app_tile_set_app (GS_APP_TILE (tile), app);
- return GTK_WIDGET (tile);
+ return g_object_new (GS_TYPE_POPULAR_TILE,
+ "app", app,
+ NULL);
}
diff --git a/src/gs-summary-tile.c b/src/gs-summary-tile.c
index b69283d7f..76135d428 100644
--- a/src/gs-summary-tile.c
+++ b/src/gs-summary-tile.c
@@ -239,9 +239,9 @@ gs_summary_tile_class_init (GsSummaryTileClass *klass)
}
GtkWidget *
-gs_summary_tile_new (GsApp *cat)
+gs_summary_tile_new (GsApp *app)
{
- GsAppTile *tile = g_object_new (GS_TYPE_SUMMARY_TILE, NULL);
- gs_app_tile_set_app (tile, cat);
- return GTK_WIDGET (tile);
+ return g_object_new (GS_TYPE_SUMMARY_TILE,
+ "app", app,
+ NULL);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]