[librsvg: 5/17] Compute a primitive's human-readable name early




commit e1a1b30edcabf72968cf02940e49143f2b450bd2
Author: Federico Mena Quintero <federico gnome org>
Date:   Fri Apr 16 17:20:27 2021 -0500

    Compute a primitive's human-readable name early
    
    This is just for error messages; I want to avoid using the
    primitive_node in the error code.

 src/filters/mod.rs | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/filters/mod.rs b/src/filters/mod.rs
index 49904dcc..6ac848e4 100644
--- a/src/filters/mod.rs
+++ b/src/filters/mod.rs
@@ -266,6 +266,8 @@ pub fn render(
 
             let primitive_values = elt.get_computed_values();
 
+            let primitive_name = format!("{}", primitive_node);
+
             let start = Instant::now();
 
             if let Err(err) = effect
@@ -291,7 +293,7 @@ pub fn render(
             {
                 rsvg_log!(
                     "(filter primitive {} returned an error: {})",
-                    primitive_node,
+                    primitive_name,
                     err
                 );
 
@@ -304,7 +306,7 @@ pub fn render(
             let elapsed = start.elapsed();
             rsvg_log!(
                 "(rendered filter primitive {} in\n    {} seconds)",
-                primitive_node,
+                primitive_name,
                 elapsed.as_secs() as f64 + f64::from(elapsed.subsec_nanos()) / 1e9
             );
         }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]