[gnome-photos/wip/rishi/embed-g_auto: 2/2] dlna-renderers-manager: Be more strict about what is acceptable
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-photos/wip/rishi/embed-g_auto: 2/2] dlna-renderers-manager: Be more strict about what is acceptable
- Date: Fri, 9 Apr 2021 00:12:16 +0000 (UTC)
commit 438eff6ce5502b06c0b7db9b8198975d2c662252
Author: Debarshi Ray <debarshir gnome org>
Date: Fri Apr 9 02:10:45 2021 +0200
dlna-renderers-manager: Be more strict about what is acceptable
A pointer can be non-NULL but still point to invalid memory. Hence,
it's better to assert that it's actually a valid object.
https://gitlab.gnome.org/GNOME/gnome-photos/-/merge_requests/217
src/photos-dlna-renderers-manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/photos-dlna-renderers-manager.c b/src/photos-dlna-renderers-manager.c
index 0f48f540..cfd34ab7 100644
--- a/src/photos-dlna-renderers-manager.c
+++ b/src/photos-dlna-renderers-manager.c
@@ -120,7 +120,7 @@ photos_dlna_renderers_manager_renderer_lost_cb (PhotosDlnaRenderersManager *self
gpointer renderer_data;
renderer_data = g_hash_table_lookup (self->renderers, object_path);
- g_return_if_fail (renderer_data != NULL);
+ g_return_if_fail (PHOTOS_IS_DLNA_RENDERER (renderer_data));
renderer = PHOTOS_DLNA_RENDERER (g_object_ref (renderer_data));
g_hash_table_remove (self->renderers, object_path);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]