[gnome-shell/gnome-3-36] gdm: Always show fingerprint error messages
- From: Marge Bot <marge-bot src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gnome-3-36] gdm: Always show fingerprint error messages
- Date: Thu, 8 Apr 2021 19:33:19 +0000 (UTC)
commit e88b7c356400e3594068897b71678e0a1508e332
Author: Marco Trevisan (TreviƱo) <mail 3v1n0 net>
Date: Tue Nov 24 19:19:22 2020 +0100
gdm: Always show fingerprint error messages
When the login/lock screen is shown the error messages for background
services are always ignored.
However, in case the service is the fingerprint authentication method
we still want to be able to show error messages to inform the user
about what failed, and eventually that the max retries (that may be
different from the login screen configuration) has been reached.
This handles partially the design issue [1] related to the login/lock
screen fingerprint authentication.
Eventually we want to use pam extensions to use clearer and parse-able
messages, however in the case of the fingerprint service we can be sure
that the fprint PAM module will only send errors on auth failures.
[1] https://gitlab.gnome.org/Teams/Design/os-mockups/-/issues/56
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1784>
js/gdm/util.js | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/js/gdm/util.js b/js/gdm/util.js
index 1c82a1d0b8..7870715c85 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -491,7 +491,9 @@ var ShellUserVerifier = class {
}
_onProblem(client, serviceName, problem) {
- if (!this.serviceIsForeground(serviceName))
+ const isFingerprint = this.serviceIsFingerprint(serviceName);
+
+ if (!this.serviceIsForeground(serviceName) && !isFingerprint)
return;
this._queueMessage(problem, MessageType.ERROR);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]