[gnome-shell/gnome-3-38] gdm: Always show fingerprint error messages

[Marge Bot <marge-bot src gnome org>]

commit a9bc37088a5867e2164d72250ba362fff9f98d30
Author: Marco Trevisan (Treviño) <mail 3v1n0 net>
Date:   Tue Nov 24 19:19:22 2020 +0100

    gdm: Always show fingerprint error messages
    
    When the login/lock screen is shown the error messages for background
    services are always ignored.
    
    However, in case the service is the fingerprint authentication method
    we still want to be able to show error messages to inform the user
    about what failed, and eventually that the max retries (that may be
    different from the login screen configuration) has been reached.
    
    This handles partially the design issue [1] related to the login/lock
    screen fingerprint authentication.
    
    Eventually we want to use pam extensions to use clearer and parse-able
    messages, however in the case of the fingerprint service we can be sure
    that the fprint PAM module will only send errors on auth failures.
    
    [1] https://gitlab.gnome.org/Teams/Design/os-mockups/-/issues/56
    
    Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1783>

 js/gdm/util.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
---
diff --git a/js/gdm/util.js b/js/gdm/util.js
index 34564bae05..75219421fd 100644
--- a/js/gdm/util.js
+++ b/js/gdm/util.js
@@ -494,7 +494,9 @@ var ShellUserVerifier = class {
     }
 
     _onProblem(client, serviceName, problem) {
-        if (!this.serviceIsForeground(serviceName))
+        const isFingerprint = this.serviceIsFingerprint(serviceName);
+
+        if (!this.serviceIsForeground(serviceName) && !isFingerprint)
             return;
 
         this._queueMessage(problem, MessageType.ERROR);