[glib: 2/8] Fix signedness warning in gio/gunixsocketaddress.c




commit 1f23770bc30980cf1e4046a24b4f39de6ea8c1ed
Author: Emmanuel Fleury <emmanuel fleury gmail com>
Date:   Wed Nov 18 20:07:34 2020 +0100

    Fix signedness warning in gio/gunixsocketaddress.c
    
    gio/gunixsocketaddress.c: In function ‘g_unix_socket_address_to_native’:
    gio/gunixsocketaddress.c:217:15: error: comparison of integer expressions of different signedness: 
‘gsize’ {aka ‘long unsigned int’} and ‘gssize’ {aka ‘long int’}
      217 |   if (destlen < socklen)
          |               ^

 gio/gunixsocketaddress.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/gio/gunixsocketaddress.c b/gio/gunixsocketaddress.c
index 0ab1a62e9..69204e9b9 100644
--- a/gio/gunixsocketaddress.c
+++ b/gio/gunixsocketaddress.c
@@ -214,7 +214,8 @@ g_unix_socket_address_to_native (GSocketAddress *address,
   gssize socklen;
 
   socklen = g_unix_socket_address_get_native_size (address);
-  if (destlen < socklen)
+  g_assert (socklen >= 0);
+  if (destlen < (gsize) socklen)
     {
       g_set_error_literal (error, G_IO_ERROR, G_IO_ERROR_NO_SPACE,
                           _("Not enough space for socket address"));


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]