[libsecret/wip/dueno/secret-tool-crash] secret-tool: Fix secret_password_clearv_sync return value check




commit f632a6a9f92313e6facf37087f513fe7c22435f0
Author: Daiki Ueno <dueno src gnome org>
Date:   Sat Apr 3 06:50:37 2021 +0200

    secret-tool: Fix secret_password_clearv_sync return value check
    
    This was a regression introduced in the rewrite using the simple
    API (commit 6886aebb0457d752f348a4cedc5a11ce109544ee).
    
    Reported by Chih-Hsuan Yen in:
    https://gitlab.gnome.org/GNOME/libsecret/-/issues/56
    
    Signed-off-by: Daiki Ueno <dueno src gnome org>

 tool/secret-tool.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
---
diff --git a/tool/secret-tool.c b/tool/secret-tool.c
index 5d95194..7362549 100644
--- a/tool/secret-tool.c
+++ b/tool/secret-tool.c
@@ -141,8 +141,9 @@ secret_tool_action_clear (int argc,
 
        g_hash_table_unref (attributes);
 
-       if (!ret) {
+       if (error != NULL) {
                g_printerr ("%s: %s\n", g_get_prgname (), error->message);
+               g_error_free (error);
                return 1;
        }
 
@@ -215,6 +216,7 @@ secret_tool_action_lookup (int argc,
 
        if (error != NULL) {
                g_printerr ("%s: %s\n", g_get_prgname (), error->message);
+               g_error_free (error);
                return 1;
        }
 
@@ -482,6 +484,7 @@ secret_tool_action_search (int argc,
 
        if (error != NULL) {
                g_printerr ("%s: %s\n", g_get_prgname (), error->message);
+               g_error_free (error);
                return 1;
        }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]