[mutter/gnome-3-36] barriers: Fix leak in meta_barrier_destroy



commit 74674ddcc78b21c024b9505abf13a23467e01f50
Author: Ray Strode <rstrode redhat com>
Date:   Fri Sep 25 14:04:31 2020 -0400

    barriers: Fix leak in meta_barrier_destroy
    
    meta_barrier_destroy is responsible for removing the extra
    reference added in meta_barrier_constructed.
    
    Unfortunately, it fails to do this because of a misplaced early
    return statement.
    
    This commit removes the spurious return.
    
    https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1449
    (cherry picked from commit 97f10a0d215388c3d2870847b2d38a719bcfe001)

 src/backends/meta-barrier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/backends/meta-barrier.c b/src/backends/meta-barrier.c
index e163338cb2..ad6c8d5833 100644
--- a/src/backends/meta-barrier.c
+++ b/src/backends/meta-barrier.c
@@ -294,7 +294,7 @@ meta_barrier_destroy (MetaBarrier *barrier)
   MetaBarrierImpl *impl = barrier->priv->impl;
 
   if (impl)
-    return META_BARRIER_IMPL_GET_CLASS (impl)->destroy (impl);
+    META_BARRIER_IMPL_GET_CLASS (impl)->destroy (impl);
 
   g_object_unref (barrier);
 }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]