[gimp/wip/Jehan/warnings-test-ui: 2/2] app: remove unused function and re-enable a test.




commit 616da4f77c5e0caaaf147c281a479f5770aba792
Author: Jehan <jehan girinstud io>
Date:   Mon Sep 21 20:06:20 2020 +0200

    app: remove unused function and re-enable a test.
    
    gimp_ui_get_dialog() is not used anymore anywhere. Also a test was
    disabled with a #warning asking to re-enable when we depend on GTK+ >=
    2.24.11, which is the case now with GIMP 3!
    
    This file still has a whole bunch of warnings going on, but that's
    already 2 less.

 app/tests/test-ui.c | 30 ------------------------------
 1 file changed, 30 deletions(-)
---
diff --git a/app/tests/test-ui.c b/app/tests/test-ui.c
index cb8cf64194..599cb3ae22 100644
--- a/app/tests/test-ui.c
+++ b/app/tests/test-ui.c
@@ -143,31 +143,6 @@ tool_options_editor_updates (gconstpointer data)
                    tool_info->help_id);
 }
 
-static GtkWidget *
-gimp_ui_get_dialog (const gchar *identifier)
-{
-  GtkWidget *result = NULL;
-  GList     *iter;
-
-  for (iter = gimp_dialog_factory_get_open_dialogs (gimp_dialog_factory_get_singleton ());
-       iter;
-       iter = g_list_next (iter))
-    {
-      GtkWidget *dialog = GTK_WIDGET (iter->data);
-      GimpDialogFactoryEntry *entry = NULL;
-
-      gimp_dialog_factory_from_widget (dialog, &entry);
-
-      if (strcmp (entry->identifier, identifier) == 0)
-        {
-          result = dialog;
-          break;
-        }
-    }
-
-  return result;
-}
-
 static void
 create_new_image_via_dialog (gconstpointer data)
 {
@@ -387,10 +362,6 @@ restore_recently_closed_multi_column_dock (gconstpointer data)
                    >,
                    n_session_infos_after_close);
 
-#ifdef __GNUC__
-#warning FIXME test disabled until we depend on GTK+ >= 2.24.11
-#endif
-#if 0
   /* Restore the (only available) closed dock and make sure the session
    * infos in the global dock factory are increased again
    */
@@ -404,7 +375,6 @@ restore_recently_closed_multi_column_dock (gconstpointer data)
   g_assert_cmpint (n_session_infos_after_close,
                    <,
                    n_session_infos_after_restore);
-#endif
 }
 
 /**


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]