[gdm/wip/fix-some-fd-leaks: 3/4] session: Don't leak remote greeter interface




commit 26f2a2c5adfef9a165dbf707f2bac4b183c64d84
Author: Ray Strode <rstrode redhat com>
Date:   Tue Sep 15 00:41:00 2020 -0400

    session: Don't leak remote greeter interface
    
    XDMCP login screens get a "Remote Geeter Interface" exported over
    the bus connection (so the login window can provide a Disconnect
    button).
    
    This interface is getting leaked when the session object is disposed,
    leaving the bus connection itself undisposed, which causes an fd
    leak.
    
    This commit plugs the interface leak, and thus the fd leak.

 daemon/gdm-session.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/daemon/gdm-session.c b/daemon/gdm-session.c
index ca7d98f1..b07ffa82 100644
--- a/daemon/gdm-session.c
+++ b/daemon/gdm-session.c
@@ -3590,6 +3590,7 @@ gdm_session_dispose (GObject *object)
         g_clear_pointer (&self->user_verifier_extensions,
                          g_hash_table_unref);
         g_clear_object (&self->greeter_interface);
+        g_clear_object (&self->remote_greeter_interface);
         g_clear_object (&self->chooser_interface);
 
         g_free (self->display_name);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]