[tracker-miners/wip/carlosg/coverity-fixes] libtracker-miners-common: Check g_remove() return value




commit 83fdc0bf8a321b25353803b029f9c517f1df5fab
Author: Carlos Garnacho <carlosg gnome org>
Date:   Mon Sep 7 19:06:30 2020 +0200

    libtracker-miners-common: Check g_remove() return value
    
    Check for errors, but ignore ENOENT, since it's a likely path (we delete
    error report files for successful extraction without checks). Spotted by
    Coverity.
    
    CID: #361432

 src/libtracker-miners-common/tracker-error-report.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
---
diff --git a/src/libtracker-miners-common/tracker-error-report.c 
b/src/libtracker-miners-common/tracker-error-report.c
index e9567ee50..3cdd6f00f 100644
--- a/src/libtracker-miners-common/tracker-error-report.c
+++ b/src/libtracker-miners-common/tracker-error-report.c
@@ -22,6 +22,7 @@
 #include "tracker-error-report.h"
 
 #include <glib/gstdio.h>
+#include <errno.h>
 
 #define GROUP "Report"
 #define KEY_URI "Uri"
@@ -96,7 +97,12 @@ tracker_error_report_delete (GFile *file)
 
        uri = g_file_get_uri (file);
        report_path = get_report_file (uri);
-       g_remove (report_path);
+       if (g_remove (report_path) < 0) {
+               if (errno != ENOENT) {
+                       g_warning ("Error removing path '%s': %m",
+                                  report_path);
+               }
+       }
 
        g_free (report_path);
        g_free (uri);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]