[libhandy/tabs: 55/62] added/removed -> attached/detached

[Alexander Mikhaylenko <alexm src gnome org>]

commit 185f8e441c1f66993843116321c0b16b2e756a18
Author: Alexander Mikhaylenko <alexm gnome org>
Date:   Fri Sep 11 18:54:35 2020 +0500

    added/removed -> attached/detached

 src/hdy-tab-bar.c  |  4 ++--
 src/hdy-tab-box.c  |  4 ++--
 src/hdy-tab-view.c | 41 +++++++++++++++++++++++++++--------------
 3 files changed, 31 insertions(+), 18 deletions(-)
---
diff --git a/src/hdy-tab-bar.c b/src/hdy-tab-bar.c
index 814b5a41..ed349e8c 100644
--- a/src/hdy-tab-bar.c
+++ b/src/hdy-tab-bar.c
@@ -655,10 +655,10 @@ hdy_tab_bar_set_view (HdyTabBar  *self,
     g_signal_connect_object (self->view, "notify::selected-page",
                              G_CALLBACK (notify_selected_page_cb), self,
                              G_CONNECT_SWAPPED);
-    g_signal_connect_object (self->view, "page-added",
+    g_signal_connect_object (self->view, "page-attached",
                              G_CALLBACK (page_attached_cb), self,
                              G_CONNECT_SWAPPED);
-    g_signal_connect_object (self->view, "page-removed",
+    g_signal_connect_object (self->view, "page-detached",
                              G_CALLBACK (page_detached_cb), self,
                              G_CONNECT_SWAPPED);
     g_signal_connect_object (self->view, "destroy",
diff --git a/src/hdy-tab-box.c b/src/hdy-tab-box.c
index 047eb1bc..1a03031e 100644
--- a/src/hdy-tab-box.c
+++ b/src/hdy-tab-box.c
@@ -3326,8 +3326,8 @@ hdy_tab_box_set_view (HdyTabBox  *self,
     for (i = n_pages - 1; i >= 0; i--)
       page_attached_cb (self, hdy_tab_view_get_nth_page (self->view, i), 0);
 
-    g_signal_connect_object (self->view, "page-added", G_CALLBACK (page_attached_cb), self, 
G_CONNECT_SWAPPED);
-    g_signal_connect_object (self->view, "page-removed", G_CALLBACK (page_detached_cb), self, 
G_CONNECT_SWAPPED);
+    g_signal_connect_object (self->view, "page-attached", G_CALLBACK (page_attached_cb), self, 
G_CONNECT_SWAPPED);
+    g_signal_connect_object (self->view, "page-detached", G_CALLBACK (page_detached_cb), self, 
G_CONNECT_SWAPPED);
     g_signal_connect_object (self->view, "page-reordered", G_CALLBACK (page_reordered_cb), self, 
G_CONNECT_SWAPPED);
 
     if (!self->pinned)
diff --git a/src/hdy-tab-view.c b/src/hdy-tab-view.c
index 54058f6c..9693ef79 100644
--- a/src/hdy-tab-view.c
+++ b/src/hdy-tab-view.c
@@ -128,8 +128,8 @@ enum {
 static GParamSpec *props[LAST_PROP];
 
 enum {
-  SIGNAL_PAGE_ADDED,
-  SIGNAL_PAGE_REMOVED,
+  SIGNAL_PAGE_ATTACHED,
+  SIGNAL_PAGE_DETACHED,
   SIGNAL_PAGE_REORDERED,
   SIGNAL_CLOSE_PAGE,
   SIGNAL_SETUP_MENU,
@@ -577,7 +577,7 @@ attach_page (HdyTabView *self,
   if (pinned)
     set_n_pinned_pages (self, self->n_pages + 1);
 
-  g_signal_emit (self, signals[SIGNAL_PAGE_ADDED], 0, page, position);
+  g_signal_emit (self, signals[SIGNAL_PAGE_ATTACHED], 0, page, position);
 }
 
 static void
@@ -605,7 +605,7 @@ detach_page (HdyTabView *self,
 
   gtk_container_remove (GTK_CONTAINER (self->stack), child);
 
-  g_signal_emit (self, signals[SIGNAL_PAGE_REMOVED], 0, page, pos);
+  g_signal_emit (self, signals[SIGNAL_PAGE_DETACHED], 0, page, pos);
 
   check_close_window (self);
 
@@ -1007,17 +1007,21 @@ hdy_tab_view_class_init (HdyTabViewClass *klass)
   g_object_class_install_properties (object_class, LAST_PROP, props);
 
   /**
-   * HdyTabView::page-added:
+   * HdyTabView::page-attached:
    * @self: a #HdyTabView
    * @page: a page of @self
-   * @position: TBD
+   * @position: the position of the page, starting from 0
    *
-   * TBD
+   * This signal is emitted when a page has been created or transferred to
+   * @self.
+   *
+   * A typical reason to connect to this signal would be to connect to page
+   * signals for things such as updating window title.
    *
    * Since: 1.2
    */
-  signals[SIGNAL_PAGE_ADDED] =
-    g_signal_new ("page-added",
+  signals[SIGNAL_PAGE_ATTACHED] =
+    g_signal_new ("page-attached",
                   G_TYPE_FROM_CLASS (klass),
                   G_SIGNAL_RUN_LAST,
                   0,
@@ -1027,17 +1031,26 @@ hdy_tab_view_class_init (HdyTabViewClass *klass)
                   HDY_TYPE_TAB_PAGE, G_TYPE_INT);
 
   /**
-   * HdyTabView::page-removed:
+   * HdyTabView::page-detached:
    * @self: a #HdyTabView
    * @page: a page of @self
-   * @position: TBD
+   * @position: the position of the removed page, starting from 0
+   *
+   * This signal is emitted when a page has been removed or transferred to
+   * another view.
+   *
+   * A typical reason to connect to this signal would be to disconnect signal
+   * handlers connected in the #HdyTabView::page-attached handler.
    *
-   * TBD
+   * It is important not to try and destroy the page child in the handler of
+   * this function as the child might merely be moved to another window; use
+   * child dispose handler for that or do it in sync with your
+   * hdy_tab_view_close_page_finish() calls.
    *
    * Since: 1.2
    */
-  signals[SIGNAL_PAGE_REMOVED] =
-    g_signal_new ("page-removed",
+  signals[SIGNAL_PAGE_DETACHED] =
+    g_signal_new ("page-detached",
                   G_TYPE_FROM_CLASS (klass),
                   G_SIGNAL_RUN_LAST,
                   0,