[gnome-initial-setup/wip/pwithnall/misc-fixes: 64/70] account: Fix double-free of the UmRealmManager




commit e461d6cc3ff381563672b2edfb8f0fcaa7dbec56
Author: Philip Withnall <withnall endlessm com>
Date:   Fri Sep 11 12:03:17 2020 +0100

    account: Fix double-free of the UmRealmManager
    
    The only ref to the `UmRealmManager` was owned by `g_task_set_data()`,
    and was being freed when the `GTask` was finalised.
    
    Signed-off-by: Philip Withnall <withnall endlessm com>

 gnome-initial-setup/pages/account/um-realm-manager.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gnome-initial-setup/pages/account/um-realm-manager.c 
b/gnome-initial-setup/pages/account/um-realm-manager.c
index 80f40c37..ba8444e8 100644
--- a/gnome-initial-setup/pages/account/um-realm-manager.c
+++ b/gnome-initial-setup/pages/account/um-realm-manager.c
@@ -158,7 +158,7 @@ on_provider_new (GObject *source,
         manager->provider = provider;
         g_dbus_proxy_set_default_timeout (G_DBUS_PROXY (manager->provider), -1);
         g_debug ("Created realm manager");
-        g_task_return_pointer (task, manager, g_object_unref);
+        g_task_return_pointer (task, g_object_ref (manager), g_object_unref);
 }
 
 static void


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]