[gtksourceview/wip/chergert/gsv-gtk4] completion: remove unused return value for filtering



commit bff99ba2d980dc13e03106136f9c7fa0e61b9e74
Author: Christian Hergert <chergert redhat com>
Date:   Tue Sep 1 16:10:03 2020 -0700

    completion: remove unused return value for filtering

 gtksourceview/gtksourcecompletionprovider.c | 15 ++++++---------
 gtksourceview/gtksourcecompletionprovider.h |  4 ++--
 2 files changed, 8 insertions(+), 11 deletions(-)
---
diff --git a/gtksourceview/gtksourcecompletionprovider.c b/gtksourceview/gtksourcecompletionprovider.c
index 6a314a9e..526e49cf 100644
--- a/gtksourceview/gtksourcecompletionprovider.c
+++ b/gtksourceview/gtksourcecompletionprovider.c
@@ -78,12 +78,11 @@ fallback_populate (GtkSourceCompletionProvider  *provider,
        return NULL;
 }
 
-static gboolean
+static void
 fallback_refilter (GtkSourceCompletionProvider *provider,
                    GtkSourceCompletionContext  *context,
                    GListModel                  *model)
 {
-       return FALSE;
 }
 
 static void
@@ -194,19 +193,17 @@ gtk_source_completion_provider_populate_finish (GtkSourceCompletionProvider  *se
        return GTK_SOURCE_COMPLETION_PROVIDER_GET_IFACE (self)->populate_finish (self, result, error);
 }
 
-gboolean
+void
 gtk_source_completion_provider_refilter (GtkSourceCompletionProvider *self,
                                          GtkSourceCompletionContext  *context,
                                          GListModel                  *model)
 {
-       g_return_val_if_fail (GTK_SOURCE_IS_COMPLETION_PROVIDER (self), FALSE);
-       g_return_val_if_fail (GTK_SOURCE_IS_COMPLETION_CONTEXT (context), FALSE);
-       g_return_val_if_fail (G_IS_LIST_MODEL (model), FALSE);
+       g_return_if_fail (GTK_SOURCE_IS_COMPLETION_PROVIDER (self));
+       g_return_if_fail (GTK_SOURCE_IS_COMPLETION_CONTEXT (context));
+       g_return_if_fail (G_IS_LIST_MODEL (model));
 
        if (GTK_SOURCE_COMPLETION_PROVIDER_GET_IFACE (self)->refilter)
-               return GTK_SOURCE_COMPLETION_PROVIDER_GET_IFACE (self)->refilter (self, context, model);
-
-       return FALSE;
+               GTK_SOURCE_COMPLETION_PROVIDER_GET_IFACE (self)->refilter (self, context, model);
 }
 
 void
diff --git a/gtksourceview/gtksourcecompletionprovider.h b/gtksourceview/gtksourcecompletionprovider.h
index d090f00e..62f60baa 100644
--- a/gtksourceview/gtksourcecompletionprovider.h
+++ b/gtksourceview/gtksourcecompletionprovider.h
@@ -56,7 +56,7 @@ struct _GtkSourceCompletionProviderInterface
        GListModel   *(*populate_finish)      (GtkSourceCompletionProvider  *self,
                                               GAsyncResult                 *result,
                                               GError                      **error);
-       gboolean      (*refilter)             (GtkSourceCompletionProvider  *self,
+       void          (*refilter)             (GtkSourceCompletionProvider  *self,
                                               GtkSourceCompletionContext   *context,
                                               GListModel                   *model);
        void          (*display)              (GtkSourceCompletionProvider  *self,
@@ -97,7 +97,7 @@ GListModel   *gtk_source_completion_provider_populate_finish   (GtkSourceComplet
                                                                 GAsyncResult                 *result,
                                                                 GError                      **error);
 GTK_SOURCE_AVAILABLE_IN_5_0
-gboolean      gtk_source_completion_provider_refilter          (GtkSourceCompletionProvider  *self,
+void          gtk_source_completion_provider_refilter          (GtkSourceCompletionProvider  *self,
                                                                 GtkSourceCompletionContext   *context,
                                                                 GListModel                   *model);
 GTK_SOURCE_AVAILABLE_IN_5_0


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]