[gnome-shell/gnome-3-38] messageTray: Don't play sound when banners are disabled
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/gnome-3-38] messageTray: Don't play sound when banners are disabled
- Date: Tue, 27 Oct 2020 19:41:33 +0000 (UTC)
commit f359ac52b13e4769a0ddf7c9769ce5363a2d4734
Author: Florian Müllner <fmuellner gnome org>
Date: Tue Oct 27 00:03:43 2020 +0000
messageTray: Don't play sound when banners are disabled
When support for notification sounds was added, it made some sense
to keep the 'enable-sound' setting independent from 'show-banners'.
However that changed when 'show-banners' was rebranded in the UI as
"Do Not Disturb", as sounds are at least as disturbing as the banners.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2873
(cherry picked from commit 709c226fc3f48e6a3f5175a49b09e15bdc2dc05b)
js/ui/messageTray.js | 2 --
1 file changed, 2 deletions(-)
---
diff --git a/js/ui/messageTray.js b/js/ui/messageTray.js
index d89af2b83e..7aac503ec3 100644
--- a/js/ui/messageTray.js
+++ b/js/ui/messageTray.js
@@ -784,8 +784,6 @@ var Source = GObject.registerClass({
if (this.policy.showBanners || notification.urgency == Urgency.CRITICAL)
this.emit('notification-show', notification);
- else
- notification.playSound();
}
notify(propName) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]