[gtk/matthiasc/atspi-child] stack: Don't transition when the visible child is remove



commit 434b145ee0199989c1772706ef1dec0722fc75f2
Author: Matthias Clasen <mclasen redhat com>
Date:   Sat Oct 24 20:54:55 2020 -0400

    stack: Don't transition when the visible child is remove
    
    This is a corner-case, and it is causing crashes in
    the shortcuts window, after a11ab6c995a38fde0eba.

 gtk/gtkstack.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)
---
diff --git a/gtk/gtkstack.c b/gtk/gtkstack.c
index e1a24b7763..b06bc3629d 100644
--- a/gtk/gtkstack.c
+++ b/gtk/gtkstack.c
@@ -1474,12 +1474,7 @@ stack_remove (GtkStack  *stack,
   was_visible = gtk_widget_get_visible (child);
 
   if (priv->visible_child == child_info)
-    {
-      if (in_dispose)
-        priv->visible_child = NULL;
-      else
-        set_visible_child (stack, NULL, priv->transition_type, priv->transition_duration);
-    }
+    priv->visible_child = NULL;
 
   if (priv->last_visible_child == child_info)
     priv->last_visible_child = NULL;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]