[gnome-online-accounts/wip/rishi/issue-76] web-extension-main: Remove unnecessary and unused entry point




commit 0d68e15d32efb2906a6a38aff9d0cd545fc47282
Author: Debarshi Ray <debarshir gnome org>
Date:   Wed Oct 14 21:42:23 2020 +0200

    web-extension-main: Remove unnecessary and unused entry point
    
    Since WebKitGTK 2.4, webkit_web_extension_initialize_with_user_data is
    the preferred entry point for a WebKitWebExtension. The older entry
    point (ie., webkit_web_extension_initialize) isn't sufficient and isn't
    expected to work anyway, and there's no need to define both entry
    points.
    
    Therefore, remove the definition of the older entry point to avoid
    unexpected failures if, for some reason, WebKitGTK picks the wrong
    entry point when loading the extension.
    
    https://gitlab.gnome.org/GNOME/gnome-online-accounts/-/issues/76

 src/goabackend/goawebextensionmain.c | 7 -------
 1 file changed, 7 deletions(-)
---
diff --git a/src/goabackend/goawebextensionmain.c b/src/goabackend/goawebextensionmain.c
index 4fc91e5c..061825f7 100644
--- a/src/goabackend/goawebextensionmain.c
+++ b/src/goabackend/goawebextensionmain.c
@@ -27,15 +27,8 @@
 static GoaWebExtension *the_extension;
 
 /* Silence -Wmissing-prototypes */
-void webkit_web_extension_initialize (WebKitWebExtension *wk_extension);
 void webkit_web_extension_initialize_with_user_data (WebKitWebExtension *wk_extension, GVariant *user_data);
 
-G_MODULE_EXPORT void
-webkit_web_extension_initialize (WebKitWebExtension *wk_extension)
-{
-  g_warning ("Error initializing web extension: user data not set");
-}
-
 G_MODULE_EXPORT void
 webkit_web_extension_initialize_with_user_data (WebKitWebExtension *wk_extension, GVariant *user_data)
 {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]