[gnome-calendar/mcatanzaro/#647: 2/2] gcal-timeline: completed_calendars should be unsigned
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-calendar/mcatanzaro/#647: 2/2] gcal-timeline: completed_calendars should be unsigned
- Date: Tue, 13 Oct 2020 17:27:28 +0000 (UTC)
commit 83ce3ab059158d769de86bb828b820cb7661f1db
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Tue Oct 13 12:05:28 2020 -0500
gcal-timeline: completed_calendars should be unsigned
In on_calendar_monitor_completed_cb() we have this assert:
g_assert (self->completed_calendars <= g_hash_table_size (self->calendars));
That is comparing a signed integer to unsigned. This is dangerous. We
could add casts to say that we really want to do it, but
completed_calendars should never be negative, so might as well use
unsigned.
src/core/gcal-timeline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/src/core/gcal-timeline.c b/src/core/gcal-timeline.c
index 4e24842b..dcec4cb3 100644
--- a/src/core/gcal-timeline.c
+++ b/src/core/gcal-timeline.c
@@ -70,7 +70,7 @@ struct _GcalTimeline
gchar *filter;
GHashTable *calendars; /* GcalCalendar* -> GcalCalendarMonitor* */
- gint completed_calendars;
+ guint completed_calendars;
GHashTable *subscribers; /* GcalTimelineSubscriber* -> SubscriberData* */
GcalRangeTree *subscriber_ranges;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]