[rhythmbox: 1/2] rating: emit 'rated' signal when rating is updated via keyboard too




commit b98f619600241f0b92c3890cf7486579a4d267d2
Author: crvi <crvisqr gmail com>
Date:   Sun Feb 16 09:55:34 2020 +0530

    rating: emit 'rated' signal when rating is updated via keyboard too
    
    Closes: #1773

 widgets/rb-rating.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)
---
diff --git a/widgets/rb-rating.c b/widgets/rb-rating.c
index 1f7724a55..744fb715b 100644
--- a/widgets/rb-rating.c
+++ b/widgets/rb-rating.c
@@ -455,14 +455,27 @@ rb_rating_button_press_cb (GtkWidget *widget,
 static gboolean
 rb_rating_set_rating_cb (RBRating *rating, gdouble score)
 {
-       rb_rating_set_rating (rating, score);
+       g_signal_emit (G_OBJECT (rating), rb_rating_signals[RATED], 0, score);
+
        return TRUE;
 }
 
 static gboolean
 rb_rating_adjust_rating_cb (RBRating *rating, gdouble adjust)
 {
-       rb_rating_set_rating (rating, rating->priv->rating + adjust);
+       gdouble new_rating;
+
+       new_rating = rating->priv->rating + adjust;
+
+       /* clip to the rating range */
+       if (new_rating > RB_RATING_MAX_SCORE) {
+               new_rating = RB_RATING_MAX_SCORE;
+       } else if (new_rating < 0.0) {
+               new_rating = 0.0;
+       }
+
+       g_signal_emit (G_OBJECT (rating), rb_rating_signals[RATED], 0, new_rating);
+
        return TRUE;
 }
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]