[orca] Resume using AT-SPI2 cache for accessible parents in Chromium



commit e26f4ff308603cf55ec595ccdc026c8b52b5de3d
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Thu Oct 8 11:21:38 2020 +0200

    Resume using AT-SPI2 cache for accessible parents in Chromium
    
    We had to stop using the AT-SPI2 cache for parents because Chromium
    was failing to emit parent-changed events causing us to not see
    parts of the page and/or getting stuck. This happened, for example,
    on the Github issue page with the search field.
    
    Recently I fixed this problem in Chromium itself. Therefore we can
    resume using the AT-SPI2 cache for parents.

 src/orca/scripts/toolkits/Chromium/script.py | 10 ----------
 1 file changed, 10 deletions(-)
---
diff --git a/src/orca/scripts/toolkits/Chromium/script.py b/src/orca/scripts/toolkits/Chromium/script.py
index 151845fff..653cf1639 100644
--- a/src/orca/scripts/toolkits/Chromium/script.py
+++ b/src/orca/scripts/toolkits/Chromium/script.py
@@ -47,16 +47,6 @@ class Script(web.Script):
 
         self.presentIfInactive = False
 
-        # Chromium doesn't always emit parent-change events. While we don't listen
-        # for those ourselves, those events tell AT-SPI2 to update the cached parent.
-        # If we cache the parent, then we can wind up getting stuck. Example page is
-        # the Github issue page when the issue search field gets focus.
-        app.setCacheMask(pyatspi.cache.DEFAULT ^
-                         pyatspi.cache.CHILDREN ^
-                         pyatspi.cache.PARENT ^
-                         pyatspi.cache.NAME ^
-                         pyatspi.cache.DESCRIPTION)
-
     def getBrailleGenerator(self):
         """Returns the braille generator for this script."""
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]