[gnome-shell] workspacesView: Always clip to allocation
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell] workspacesView: Always clip to allocation
- Date: Fri, 2 Oct 2020 18:29:42 +0000 (UTC)
commit 6ce4605c3adb6933deb26d89ed0638298830b0df
Author: Florian Müllner <fmuellner gnome org>
Date: Mon Aug 31 21:11:18 2020 +0200
workspacesView: Always clip to allocation
We couldn't clip workspaces views during the overview transition
when we used the "porthole" approach, but as view's allocation
now always matches the expected visible area, we can just apply
the clip unconditionally.
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/3208
js/ui/workspacesView.js | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
---
diff --git a/js/ui/workspacesView.js b/js/ui/workspacesView.js
index c3ad4b6cf0..3b38bee02a 100644
--- a/js/ui/workspacesView.js
+++ b/js/ui/workspacesView.js
@@ -74,6 +74,7 @@ class WorkspacesView extends WorkspacesViewBase {
let workspaceManager = global.workspace_manager;
super._init(monitorIndex);
+ this.clip_to_allocation = true;
this._animating = false; // tweening
this._gestureActive = false; // touch(pad) gestures
@@ -96,10 +97,6 @@ class WorkspacesView extends WorkspacesViewBase {
(ws, i) => this.set_child_at_index(ws, i));
});
- this._overviewShownId = Main.overview.connect('shown', () => {
- this.clip_to_allocation = true;
- });
-
this._switchWorkspaceNotifyId =
global.window_manager.connect('switch-workspace',
this._activeWorkspaceChanged.bind(this));
@@ -147,8 +144,6 @@ class WorkspacesView extends WorkspacesViewBase {
}
animateFromOverview(animationType) {
- this.clip_to_allocation = false;
-
for (let w = 0; w < this._workspaces.length; w++) {
if (animationType == AnimationType.ZOOM)
this._workspaces[w].zoomFromOverview();
@@ -232,7 +227,6 @@ class WorkspacesView extends WorkspacesViewBase {
super._onDestroy();
this._scrollAdjustment.disconnect(this._onScrollId);
- Main.overview.disconnect(this._overviewShownId);
global.window_manager.disconnect(this._switchWorkspaceNotifyId);
let workspaceManager = global.workspace_manager;
workspaceManager.disconnect(this._updateWorkspacesId);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]