[gjs: 2/12] CI: Remove false positive includes




commit be9bb2c06a65dd8fccb4e0bcfe51b30871a22dd8
Author: Philip Chimento <philip chimento gmail com>
Date:   Mon Nov 23 22:12:16 2020 -0800

    CI: Remove false positive includes
    
    There were a few instances of this false positive already in the code base
    so remove those includes and add the files to the false positive list.

 gi/boxed.cpp                  | 5 ++---
 gi/object.cpp                 | 1 -
 gjs/context.cpp               | 1 -
 test/gjs-test-jsapi-utils.cpp | 1 -
 tools/process_iwyu.py         | 7 +++++++
 5 files changed, 9 insertions(+), 6 deletions(-)
---
diff --git a/gi/boxed.cpp b/gi/boxed.cpp
index d349e3d2..49c999ee 100644
--- a/gi/boxed.cpp
+++ b/gi/boxed.cpp
@@ -7,9 +7,8 @@
 #include <stdint.h>
 #include <string.h>  // for memcpy, size_t, strcmp
 
-#include <string>       // for string
-#include <type_traits>  // for remove_reference
-#include <utility>      // for move, forward
+#include <string>
+#include <utility>  // for move, forward
 
 #include <girepository.h>
 #include <glib-object.h>
diff --git a/gi/object.cpp b/gi/object.cpp
index 0e5853cc..653fc093 100644
--- a/gi/object.cpp
+++ b/gi/object.cpp
@@ -12,7 +12,6 @@
 #include <functional>  // for mem_fn
 #include <string>
 #include <tuple>        // for tie
-#include <type_traits>  // for remove_reference<>::type
 #include <utility>      // for move
 #include <vector>
 
diff --git a/gjs/context.cpp b/gjs/context.cpp
index 401583c7..6131e641 100644
--- a/gjs/context.cpp
+++ b/gjs/context.cpp
@@ -17,7 +17,6 @@
 
 #include <new>
 #include <string>       // for u16string
-#include <type_traits>  // for remove_reference<>::type
 #include <unordered_map>
 #include <utility>  // for move
 #include <vector>
diff --git a/test/gjs-test-jsapi-utils.cpp b/test/gjs-test-jsapi-utils.cpp
index c97cbd7d..b66cd548 100644
--- a/test/gjs-test-jsapi-utils.cpp
+++ b/test/gjs-test-jsapi-utils.cpp
@@ -8,7 +8,6 @@
 #include <glib-object.h>
 #include <glib.h>
 #include <stddef.h>  // for NULL
-#include <type_traits>  // for remove_reference<>::type
 #include <utility>   // for move, swap
 
 #include "gjs/jsapi-util.h"
diff --git a/tools/process_iwyu.py b/tools/process_iwyu.py
index f8f237a3..521dc951 100755
--- a/tools/process_iwyu.py
+++ b/tools/process_iwyu.py
@@ -77,15 +77,22 @@ FALSE_POSITIVES = (
     ('gi/arg-cache.cpp', '#include <type_traits>', 'for enable_if_t'),
 
     # False positive when using GjsAutoPointer
+    ('gi/boxed.cpp', '#include <type_traits>', 'for remove_reference<>::type'),
+    ('gi/object.cpp', '#include <type_traits>',
+     'for remove_reference<>::type'),
     ('gi/private.cpp', '#include <type_traits>',
      'for remove_reference<>::type'),
     ('gi/value.cpp', '#include <type_traits>', 'for remove_reference<>::type'),
+    ('gjs/context.cpp', '#include <type_traits>',
+     'for remove_reference<>::type'),
     ('gjs/debugger.cpp', '#include <type_traits>',
      'for remove_reference<>::type'),
     ('gjs/importer.cpp', '#include <type_traits>',
      'for remove_reference<>::type'),
     ('gjs/profiler.cpp', '#include <type_traits>',
      'for remove_reference<>::type'),
+    ('test/gjs-test-jsapi-utils.cpp', '#include <type_traits>',
+     'for remove_reference<>::type'),
 
     # Weird false positive on some versions of IWYU
     ('gi/arg.cpp', 'struct _GHashTable;', ''),


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]