[gnome-builder] build: fix warnings from Clang
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] build: fix warnings from Clang
- Date: Mon, 23 Nov 2020 23:50:01 +0000 (UTC)
commit 7bca7fa3c2d714adc97f2c78ab9aae4894c9205c
Author: Christian Hergert <chergert redhat com>
Date: Mon Nov 23 15:54:10 2020 -0800
build: fix warnings from Clang
src/libide/gui/ide-notification-view.c | 1 -
src/libide/terminal/ide-terminal-launcher.c | 5 ++---
src/plugins/shellcmd/gbp-shellcmd-command.c | 1 -
3 files changed, 2 insertions(+), 5 deletions(-)
---
diff --git a/src/libide/gui/ide-notification-view.c b/src/libide/gui/ide-notification-view.c
index 8b160aee9..a3e52844b 100644
--- a/src/libide/gui/ide-notification-view.c
+++ b/src/libide/gui/ide-notification-view.c
@@ -71,7 +71,6 @@ connect_notification (IdeNotificationView *self,
{
g_autofree gchar *action_name = NULL;
g_autoptr(GVariant) target_value = NULL;
- g_autoptr(GIcon) icon = NULL;
guint n_buttons;
g_assert (IDE_IS_NOTIFICATION_VIEW (self));
diff --git a/src/libide/terminal/ide-terminal-launcher.c b/src/libide/terminal/ide-terminal-launcher.c
index 4d679d2bc..71c629b32 100644
--- a/src/libide/terminal/ide-terminal-launcher.c
+++ b/src/libide/terminal/ide-terminal-launcher.c
@@ -387,10 +387,8 @@ spawn_runner_launcher (IdeTerminalLauncher *self,
gint pty_fd)
{
g_autoptr(IdeSimpleBuildTarget) build_target = NULL;
- g_autoptr(IdeSubprocess) subprocess = NULL;
g_autoptr(IdeRunner) runner = NULL;
g_autoptr(GPtrArray) argv = NULL;
- g_autoptr(GError) error = NULL;
IdeEnvironment *env;
const gchar *shell;
@@ -851,8 +849,9 @@ ide_terminal_launcher_set_args (IdeTerminalLauncher *self,
if ((gchar **)args != self->args)
{
- g_auto(GStrv) freeme = g_steal_pointer (&self->args);
+ gchar **freeme = g_steal_pointer (&self->args);
self->args = g_strdupv ((gchar **)args);
g_object_notify_by_pspec (G_OBJECT (self), properties [PROP_ARGS]);
+ g_strfreev (freeme);
}
}
diff --git a/src/plugins/shellcmd/gbp-shellcmd-command.c b/src/plugins/shellcmd/gbp-shellcmd-command.c
index 4a79e018f..9815e7711 100644
--- a/src/plugins/shellcmd/gbp-shellcmd-command.c
+++ b/src/plugins/shellcmd/gbp-shellcmd-command.c
@@ -486,7 +486,6 @@ gbp_shellcmd_command_run_app (GbpShellcmdCommand *self,
g_autoptr(IdeSubprocessLauncher) launcher = NULL;
g_autoptr(IdeTerminalLauncher) tlauncher = NULL;
g_autoptr(IdeContext) context = NULL;
- g_autoptr(GError) error = NULL;
g_autoptr(GFile) workdir = NULL;
IdeWorkspace *workspace;
IdeWorkbench *workbench;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]