[libmanette] device: Add a missing precondition check to *_rumble()



commit 0e847702f08dd0c4491a9ff0444a17a22de8af53
Author: Adrien Plazas <kekun plazas laposte net>
Date:   Tue Nov 17 22:25:39 2020 +0100

    device: Add a missing precondition check to *_rumble()
    
    This ensures we don't pass invalid values to the device and it helps the
    developers know they misused our API.

 src/manette-device.c | 1 +
 1 file changed, 1 insertion(+)
---
diff --git a/src/manette-device.c b/src/manette-device.c
index 81fc043..bbdecd2 100644
--- a/src/manette-device.c
+++ b/src/manette-device.c
@@ -865,6 +865,7 @@ manette_device_rumble (ManetteDevice *self,
   struct input_event event;
 
   g_return_val_if_fail (MANETTE_IS_DEVICE (self), FALSE);
+  g_return_val_if_fail (milliseconds <= G_MAXINT16, FALSE);
 
   self->rumble_effect.u.rumble.strong_magnitude = strong_magnitude;
   self->rumble_effect.u.rumble.weak_magnitude = weak_magnitude;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]