[gnome-music/wip/jfelder/unused-selection-changed] songwidget: Remove unused signal 'selection-changed'




commit fba2bd08de538d18381ddc73e4ce56f054f7e170
Author: Jean Felder <jfelder src gnome org>
Date:   Thu Nov 12 00:46:00 2020 +0100

    songwidget: Remove unused signal 'selection-changed'
    
    It is not used anymore. All the selection logic now relies on GObject
    properties.

 data/ui/SongWidget.ui            | 1 -
 gnomemusic/widgets/songwidget.py | 5 -----
 2 files changed, 6 deletions(-)
---
diff --git a/data/ui/SongWidget.ui b/data/ui/SongWidget.ui
index 240a707e7..8280ce9db 100644
--- a/data/ui/SongWidget.ui
+++ b/data/ui/SongWidget.ui
@@ -5,7 +5,6 @@
   <template class="SongWidget" parent="GtkEventBox">
     <property name="visible">True</property>
     <property name="can_focus">False</property>
-    <signal name="notify::selected" handler="_on_selection_changed"/>
     <signal name="drag_data_received" handler="_on_drag_data_received"/>
     <child>
       <object class="GtkBox" id="box1">
diff --git a/gnomemusic/widgets/songwidget.py b/gnomemusic/widgets/songwidget.py
index 1c494e07a..c90861d9e 100644
--- a/gnomemusic/widgets/songwidget.py
+++ b/gnomemusic/widgets/songwidget.py
@@ -51,7 +51,6 @@ class SongWidget(Gtk.EventBox):
     __gtype_name__ = 'SongWidget'
 
     __gsignals__ = {
-        'selection-changed': (GObject.SignalFlags.RUN_FIRST, None, ()),
         "widget-moved": (GObject.SignalFlags.RUN_FIRST, None, (int,))
     }
 
@@ -160,10 +159,6 @@ class SongWidget(Gtk.EventBox):
             self.drag_dest_set(
                 Gtk.DestDefaults.ALL, entries, Gdk.DragAction.MOVE)
 
-    @Gtk.Template.Callback()
-    def _on_selection_changed(self, klass, value):
-        self.emit('selection-changed')
-
     @Gtk.Template.Callback()
     def _on_drag_begin(self, klass, context):
         gdk_window = self.get_window()


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]