[gtk/matthiasc/for-master: 15/17] Don't hide widgets in dispose()




commit 27c4c19333af35e15f834ecc1cde3ad2cb94b6e3
Author: Matthias Clasen <mclasen redhat com>
Date:   Tue Nov 10 15:07:07 2020 -0500

    Don't hide widgets in dispose()
    
    This is leftover code from when widgets were hidden
    by default, and was setting them back to their initial
    state.
    
    This is getting in the way now, as hiding the widget
    updates the HIDDEN accessible state, which ends up
    re-creating the at context that we've already disposed
    of, leading to memory leaks.

 gtk/gtkwidget.c | 2 --
 1 file changed, 2 deletions(-)
---
diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c
index c29cc88ec0..8d6e4067d5 100644
--- a/gtk/gtkwidget.c
+++ b/gtk/gtkwidget.c
@@ -7040,8 +7040,6 @@ gtk_widget_dispose (GObject *object)
 
   if (priv->parent)
     gtk_widget_unparent (widget);
-  else if (_gtk_widget_get_visible (widget))
-    gtk_widget_hide (widget);
 
   while (priv->paintables)
     gtk_widget_paintable_set_widget (priv->paintables->data, NULL);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]