[gtk/ebassi/for-master: 2/4] a11y: Use "presentation" role instead of "hidden" state

[Emmanuele Bassi <ebassi src gnome org>]

commit 88116712f6508ee7d48fa991ce8335b1b9d6b95b
Author: Emmanuele Bassi <ebassi gnome org>
Date:   Thu Nov 5 13:19:26 2020 +0000

    a11y: Use "presentation" role instead of "hidden" state
    
    The intended use case of the "presentation" role is
    
    | […] when an element is used to change the look of the page but does not
    | have all the functional, interactive, or structural relevance implied
    | by the element type, or may be used to provide for an accessible
    | fallback in older browsers that do not support WAI-ARIA.
    
    One of the examples is, literally:
    
    | An element whose content is completely presentational (like a spacer
    | image, decorative graphic, or clearing element);
    
    Which fits perfectly for the GtkTreeExpander's "indent" builtin icon
    widget.

 gtk/gtktreeexpander.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)
---
diff --git a/gtk/gtktreeexpander.c b/gtk/gtktreeexpander.c
index 9ff4e6ac35..ec57b28ced 100644
--- a/gtk/gtktreeexpander.c
+++ b/gtk/gtktreeexpander.c
@@ -201,14 +201,13 @@ gtk_tree_expander_update_for_list_row (GtkTreeExpander *self)
             child = gtk_widget_get_prev_sibling (child);
           else
             {
-              GtkWidget *indent = gtk_builtin_icon_new ("indent");
+              GtkWidget *indent =
+                g_object_new (GTK_TYPE_BUILTIN_ICON,
+                              "css-name", "indent",
+                              "accessible-role", GTK_ACCESSIBLE_ROLE_PRESENTATION,
+                              NULL);
 
               gtk_widget_insert_after (indent, GTK_WIDGET (self), NULL);
-
-              /* The indent icon is not visible in the accessibility tree */
-              gtk_accessible_update_state (GTK_ACCESSIBLE (indent),
-                                           GTK_ACCESSIBLE_STATE_HIDDEN, TRUE,
-                                           -1);
             }
         }