[librsvg: 1/2] Remove deny(warnings) from the toplevel src/lib.rs




commit 97c6b79a5e3fce561f7c1c9881478dc7ab92120a
Author: Federico Mena Quintero <federico gnome org>
Date:   Tue Nov 3 11:19:03 2020 -0600

    Remove deny(warnings) from the toplevel src/lib.rs
    
    This got moved from librsvg_crate/src/lib.rs, where it was presumably
    because we didn't want warnings in the public API crate.  Now that
    we have a single crate, however, this can create warnings on
    architectures which we don't test in the CI.
    
    Specifically, this was causing this warning-as-error in
    gnome-build-meta for aarch64:
    
            ======================================================================
            345 | |         rsvg_pixbuf_from_file_at_max_size => ptr::null_mut();
            346 | |
            347 | |         !filename.is_null(),
            348 | |         max_width >= 1 && max_height >= 1,
            349 | |         error.is_null() || (*error).is_null(),
            350 | |     }
                | |_____- in this macro invocation
                |
                = help: cast can be replaced by coercion; this might require a temporary variable
                = note: this error originates in a macro (in Nightly builds, run with -Z macro-backtrace for 
more info)
            error: trivial cast: `*const u8` as `*const u8`
               --> src/c_api/messages.rs:112:21
                |
            112 |                       concat!(stringify!($func_name), "\0").as_ptr() as *const _,
                |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                |
               ::: src/c_api/pixbuf_utils.rs:344:5
                |
            344 | /     rsvg_return_val_if_fail! {
            345 | |         rsvg_pixbuf_from_file_at_max_size => ptr::null_mut();
            346 | |
            347 | |         !filename.is_null(),
            348 | |         max_width >= 1 && max_height >= 1,
            349 | |         error.is_null() || (*error).is_null(),
            350 | |     }
                | |_____- in this macro invocation

 src/lib.rs | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/src/lib.rs b/src/lib.rs
index 578445f4..082dedb1 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -61,7 +61,6 @@
 #![warn(renamed_and_removed_lints)]
 // Standalone lints
 #![warn(trivial_casts, trivial_numeric_casts)]
-#![deny(warnings)]
 
 // The public API is exported here
 pub use crate::api::*;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]