[gnome-weather/wip/cdavis/diagnostics-cleanup: 7/7] ui: Minimize use of child props




commit bea7ff94fce8003265258cca2f639619dbfa4453
Author: Christopher Davis <brainblasted disroot org>
Date:   Fri Oct 23 20:08:02 2020 -0700

    ui: Minimize use of child props
    
    Remove all redundant child properties. Child
    properties are gone in GTK4, and we should
    minimize their use to what's absolutely necessary
    in GTK3.
    
    Related to https://gitlab.gnome.org/GNOME/gnome-weather/-/issues/122

 data/day-entry.ui      | 34 ----------------------------------
 data/hour-entry.ui     | 15 ---------------
 data/weather-widget.ui |  1 -
 3 files changed, 50 deletions(-)
---
diff --git a/data/day-entry.ui b/data/day-entry.ui
index e1a6229..b1c42ab 100644
--- a/data/day-entry.ui
+++ b/data/day-entry.ui
@@ -294,10 +294,6 @@
           <placeholder/>
         </child>
       </object>
-      <packing>
-        <property name="submenu">main</property>
-        <property name="position">1</property>
-      </packing>
     </child>
   </object>
   <template class="Gjs_DayEntry" parent="GtkBox">
@@ -316,11 +312,6 @@
         <property name="margin_top">8</property>
         <property name="label">Tues</property>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">0</property>
-      </packing>
     </child>
     <child>
       <object class="GtkLabel" id="dateLabel">
@@ -329,11 +320,6 @@
         <property name="margin_top">8</property>
         <property name="label">7 June</property>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">1</property>
-      </packing>
     </child>
     <child>
       <object class="GtkImage" id="image">
@@ -344,11 +330,6 @@
         <property name="pixel_size">32</property>
         <property name="icon_name">weather-showers-symbolic</property>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">2</property>
-      </packing>
     </child>
     <child>
       <object class="GtkLabel" id="maxTemperatureLabel">
@@ -357,11 +338,6 @@
         <property name="margin_top">8</property>
         <property name="label">18°</property>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">3</property>
-      </packing>
     </child>
     <child>
       <object class="GtkLabel" id="minTemperatureLabel">
@@ -370,11 +346,6 @@
         <property name="margin_top">8</property>
         <property name="label">9°</property>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">4</property>
-      </packing>
     </child>
     <child>
       <object class="GtkMenuButton">
@@ -397,11 +368,6 @@
           <class name="flat"/>
         </style>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">5</property>
-      </packing>
     </child>
   </template>
 </interface>
diff --git a/data/hour-entry.ui b/data/hour-entry.ui
index a8821d8..0c27049 100644
--- a/data/hour-entry.ui
+++ b/data/hour-entry.ui
@@ -19,11 +19,6 @@
         <property name="can_focus">False</property>
         <property name="label">Now</property>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">0</property>
-      </packing>
     </child>
     <child>
       <object class="GtkImage" id="image">
@@ -34,11 +29,6 @@
         <property name="pixel_size">32</property>
         <property name="icon_name">weather-showers-symbolic</property>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">1</property>
-      </packing>
     </child>
     <child>
       <object class="GtkLabel" id="temperatureLabel">
@@ -50,11 +40,6 @@
           <class name="forecast-temperature-label"/>
         </style>
       </object>
-      <packing>
-        <property name="expand">False</property>
-        <property name="fill">True</property>
-        <property name="position">2</property>
-      </packing>
     </child>
   </template>
 </interface>
diff --git a/data/weather-widget.ui b/data/weather-widget.ui
index 0e64d14..4413778 100644
--- a/data/weather-widget.ui
+++ b/data/weather-widget.ui
@@ -67,7 +67,6 @@
                         <property name="name">daily</property>
                         <property name="title" translatable="yes">Daily</property>
                         <property name="icon-name">x-office-calendar-symbolic</property>
-                        <property name="position">1</property>
                       </packing>
                     </child>
                   </object>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]