[gdm/wip/libgdm-proxy-leaks: 1/3] libgdm: Fix client leaks from g_async_result_get_source_object




commit c86e4f76a50a643fb975da76230f2ab965ac223e
Author: Ray Strode <rstrode redhat com>
Date:   Sun Sep 27 01:06:37 2020 -0400

    libgdm: Fix client leaks from g_async_result_get_source_object
    
    There are are few places in the code where the client object is
    retrieved via g_async_result_get_source_object.  Those calls
    return a fresh reference that is never unreferenced later.
    
    This commit plugs those leaks by using g_autoptr's

 libgdm/gdm-client.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/libgdm/gdm-client.c b/libgdm/gdm-client.c
index 1686161d6..2c7b86731 100644
--- a/libgdm/gdm-client.c
+++ b/libgdm/gdm-client.c
@@ -191,7 +191,7 @@ on_user_verifier_choice_list_proxy_created (GObject            *source,
                                             GAsyncResult       *result,
                                             UserVerifierData   *data)
 {
-        GdmClient                 *client;
+        g_autoptr(GdmClient)       client = NULL;
         GdmUserVerifierChoiceList *choice_list;
         g_autoptr(GError)          error = NULL;
 
@@ -214,7 +214,7 @@ on_user_verifier_extensions_enabled (GdmUserVerifier    *user_verifier,
                                      GAsyncResult       *result,
                                      UserVerifierData   *data)
 {
-        GdmClient *client;
+        g_autoptr(GdmClient)       client = NULL;
         GCancellable *cancellable;
         GDBusConnection *connection;
         g_autoptr(GError) error = NULL;
@@ -277,7 +277,7 @@ on_user_verifier_proxy_created (GObject            *source,
                                 GAsyncResult       *result,
                                 gpointer            user_data)
 {
-        GdmClient       *self;
+        g_autoptr(GdmClient)       self = NULL;
         GCancellable    *cancellable = NULL;
         g_autoptr(GdmUserVerifier) user_verifier = NULL;
         g_autoptr(GTask)           task = user_data;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]