[gnome-shell/wip/carlosg/pad-osd-fixes: 6/6] padOsd: Apply specific CSS to Button/Leader SVG classes
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/pad-osd-fixes: 6/6] padOsd: Apply specific CSS to Button/Leader SVG classes
- Date: Fri, 29 May 2020 17:42:35 +0000 (UTC)
commit 2448c72c45d1c64bd302deaf2be73b93894157e2
Author: Carlos Garnacho <carlosg gnome org>
Date: Fri May 29 17:12:09 2020 +0200
padOsd: Apply specific CSS to Button/Leader SVG classes
Applying a fill operation on the Leader line path seems to close
it, resulting in filled polygon. Bug or not this is not the intended
result here, we can do less ambiguously by not specifying the fill
CSS property to the Leader class.
Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2570
https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1290
js/ui/padOsd.js | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
---
diff --git a/js/ui/padOsd.js b/js/ui/padOsd.js
index 9b0170d7d5..86452915e0 100644
--- a/js/ui/padOsd.js
+++ b/js/ui/padOsd.js
@@ -383,10 +383,8 @@ var PadDiagram = GObject.registerClass({
for (let i = 0; i < this._activeButtons.length; i++) {
let ch = String.fromCharCode('A'.charCodeAt() + this._activeButtons[i]);
- css += '.%s {'.format(ch);
- css += ' stroke: %s !important;'.format(ACTIVE_COLOR);
- css += ' fill: %s !important;'.format(ACTIVE_COLOR);
- css += '}';
+ css += '.%s.Leader { stroke: %s !important; }'.format(ch, ACTIVE_COLOR);
+ css += '.%s.Button { stroke: %s !important; fill: %s !important; }'.format(ch, ACTIVE_COLOR,
ACTIVE_COLOR);
}
return css;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]