[gnome-shell/gbsneto/custom-icon-positions: 9/35] appDisplay: Redisplay folders before AppDisplay

[Georges Basile Stavracas Neto <gbsneto src gnome org>]

commit f794c63920d1a442a8236b704efbebbec4a9f24c
Author: Georges Basile Stavracas Neto <georges stavracas gmail com>
Date:   Tue May 19 17:32:22 2020 -0300

    appDisplay: Redisplay folders before AppDisplay
    
    When filtering out the app icons, AppDisplay calls FolderIcon.getAppIds(),
    which then calls FolderView.getAllItems(). This last function reads the
    already added app icons inside the given folder, and return their app ids.
    
    So far, so good.
    
    When the GSettings backing a folder changes, FolderIcon emits 'apps-changed'
    to notify AppDisplay that the folder changed.
    
    Cool.
    
    When AppDisplay receives this signal, it first recreates its own icons, then
    updates the folders, and finally hides the icons that are inside folders.
    
    This series of events is unfortunate. Future patches will need the folder
    to be updated *before* AppDisplay updates its own icons.
    
    Update folder icons before chaining up to BaseAppView._redisplay().
    
    https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1271

 js/ui/appDisplay.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/js/ui/appDisplay.js b/js/ui/appDisplay.js
index 3191bcbece..be368e058f 100644
--- a/js/ui/appDisplay.js
+++ b/js/ui/appDisplay.js
@@ -457,11 +457,11 @@ class AppDisplay extends BaseAppView {
     }
 
     _redisplay() {
-        super._redisplay();
-
         this._folderIcons.forEach(icon => {
             icon.view._redisplay();
         });
+
+        super._redisplay();
         this._refilterApps();
     }