[gnome-music/wip/jfelder/baseview-must-die: 21/24] songsview: Inherit from GtkBox



commit 96011fcfd2c8e2ac261186fdd9f40ebcfab6a794
Author: Jean Felder <jfelder src gnome org>
Date:   Tue May 26 23:05:13 2020 +0200

    songsview: Inherit from GtkBox
    
    There is no point in using GtkStack.

 data/ui/SongsView.ui          | 2 +-
 gnomemusic/views/songsview.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/data/ui/SongsView.ui b/data/ui/SongsView.ui
index 382efb01..8a3f71fb 100644
--- a/data/ui/SongsView.ui
+++ b/data/ui/SongsView.ui
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
   <requires lib="gtk+" version="3.18"/>
-  <template class="SongsView" parent="GtkStack">
+  <template class="SongsView" parent="GtkBox">
     <property name="visible">True</property>
     <child>
       <object class="GtkScrolledWindow">
diff --git a/gnomemusic/views/songsview.py b/gnomemusic/views/songsview.py
index 7e1954e5..eb064ae0 100644
--- a/gnomemusic/views/songsview.py
+++ b/gnomemusic/views/songsview.py
@@ -32,7 +32,7 @@ from gnomemusic.widgets.starhandlerwidget import StarHandlerWidget
 
 
 @Gtk.Template(resource_path="/org/gnome/Music/ui/SongsView.ui")
-class SongsView(Gtk.Stack):
+class SongsView(Gtk.Box):
     """Main view of all songs sorted artistwise
 
     Consists all songs along with songname, star, length, artist
@@ -53,7 +53,7 @@ class SongsView(Gtk.Stack):
 
         :param GtkApplication window: The application object
         """
-        super().__init__(transition_type=Gtk.StackTransitionType.CROSSFADE)
+        super().__init__()
 
         # FIXME: Make these properties.
         self.name = "songs"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]