[gnome-music/wip/jfelder/baseview-must-die: 19/24] artistsview: Inherit from GtkBox



commit 5e256315f553b930bfbbefef26d4c23d3a87df6b
Author: Jean Felder <jfelder src gnome org>
Date:   Tue May 26 23:02:44 2020 +0200

    artistsview: Inherit from GtkBox
    
    There is no point in using a GtkStack.

 data/ui/ArtistsView.ui          | 2 +-
 gnomemusic/views/artistsview.py | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/data/ui/ArtistsView.ui b/data/ui/ArtistsView.ui
index c43adfb4..8d8ffed4 100644
--- a/data/ui/ArtistsView.ui
+++ b/data/ui/ArtistsView.ui
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <interface>
   <requires lib="gtk+" version="3.18"/>
-  <template class="ArtistsView" parent="GtkStack">
+  <template class="ArtistsView" parent="GtkBox">
     <property name="visible">True</property>
     <child>
       <object class="GtkBox">
diff --git a/gnomemusic/views/artistsview.py b/gnomemusic/views/artistsview.py
index 77334963..908f5391 100644
--- a/gnomemusic/views/artistsview.py
+++ b/gnomemusic/views/artistsview.py
@@ -30,7 +30,7 @@ from gnomemusic.widgets.artisttile import ArtistTile
 
 
 @Gtk.Template(resource_path="/org/gnome/Music/ui/ArtistsView.ui")
-class ArtistsView(Gtk.Stack):
+class ArtistsView(Gtk.Box):
     """Main view of all available artists
 
     Consists of a list of artists on the left side and an overview of
@@ -48,7 +48,7 @@ class ArtistsView(Gtk.Stack):
 
         :param GtkApplication application: The application object
         """
-        super().__init__(transition_type=Gtk.StackTransitionType.CROSSFADE)
+        super().__init__()
 
         # FIXME: Make these properties.
         self.name = "artists"


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]