[gnome-shell/gnome-3-36] extensionDownloader: Replace deprecated Soup.SessionAsync



commit 40481314d2ed1889fa005ff6c0faa119b6319c83
Author: Michael Lass <bevan bi-co net>
Date:   Thu May 14 18:40:57 2020 +0000

    extensionDownloader: Replace deprecated Soup.SessionAsync
    
    Soup.SessionAsync by default sets timeout and idle_timeout to 0. This
    causes connections to hang around in state CLOSE_WAIT forever after the
    remote host has closed the connection.
    
    To fix this, we could set timeout and idle_timeout manually. However,
    Soup.SessionAsync is marked as deprecated anyway and should be replaced
    by Soup.Session. Doing so also sets a default timeout of 60 seconds.
    
    Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2774
    
    
    (cherry picked from commit a47e0f9845f936a71c9d466759d4585636e476fd)

 js/ui/extensionDownloader.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/js/ui/extensionDownloader.js b/js/ui/extensionDownloader.js
index 08ebc2fec9..90fc5a6161 100644
--- a/js/ui/extensionDownloader.js
+++ b/js/ui/extensionDownloader.js
@@ -238,7 +238,7 @@ class InstallExtensionDialog extends ModalDialog.ModalDialog {
 });
 
 function init() {
-    _httpSession = new Soup.SessionAsync({ ssl_use_system_ca_file: true });
+    _httpSession = new Soup.Session({ ssl_use_system_ca_file: true });
 
     // See: https://bugzilla.gnome.org/show_bug.cgi?id=655189 for context.
     // _httpSession.add_feature(new Soup.ProxyResolverDefault());


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]