[gnome-builder] buffer: keep IdeObject alive during save



commit 271f858b8d7d220fd0efdd0d45d2ff7a3648aa9a
Author: Christian Hergert <chergert redhat com>
Date:   Mon May 11 17:00:34 2020 -0700

    buffer: keep IdeObject alive during save
    
    We need to ensure our IdeObjectBox is not disposed (and removed from graph)
    during a save operation.

 src/libide/code/ide-buffer.c | 8 ++++++++
 1 file changed, 8 insertions(+)
---
diff --git a/src/libide/code/ide-buffer.c b/src/libide/code/ide-buffer.c
index d2dfe2486..9b02515e8 100644
--- a/src/libide/code/ide-buffer.c
+++ b/src/libide/code/ide-buffer.c
@@ -1588,6 +1588,14 @@ ide_buffer_save_file_async (IdeBuffer            *self,
   ide_task_set_source_tag (task, ide_buffer_save_file_async);
   ide_task_set_task_data (task, state, save_state_free);
 
+  /* Keep buffer alive during save operation */
+  ide_buffer_hold (self);
+  g_signal_connect_object (task,
+                           "notify::completed",
+                           G_CALLBACK (ide_buffer_release),
+                           self,
+                           G_CONNECT_SWAPPED);
+
   if (self->state == IDE_BUFFER_STATE_SAVING)
     {
       /* TODO: We could save in-flight tasks and chain to them */


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]