[gegl] workshop: rename edges-and-details to band-tune
- From: Øyvind "pippin" Kolås <ok src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gegl] workshop: rename edges-and-details to band-tune
- Date: Sun, 10 May 2020 14:50:24 +0000 (UTC)
commit 2a8d0ba88dfb81a7f949ce28992de71a62c6a4cf
Author: Øyvind Kolås <pippin gimp org>
Date: Sun May 10 14:27:41 2020 +0200
workshop: rename edges-and-details to band-tune
.../workshop/{edges-and-details.c => band-tune.c} | 29 ++++++++++------------
operations/workshop/meson.build | 2 +-
2 files changed, 14 insertions(+), 17 deletions(-)
---
diff --git a/operations/workshop/edges-and-details.c b/operations/workshop/band-tune.c
similarity index 87%
rename from operations/workshop/edges-and-details.c
rename to operations/workshop/band-tune.c
index 5a6ea4ba0..d12dab49f 100644
--- a/operations/workshop/edges-and-details.c
+++ b/operations/workshop/band-tune.c
@@ -26,33 +26,27 @@ property_double (radius1, _("Detail band"), 1.1)
description(_("Features size for detail band, used for noise removal."))
value_range (0.0, 100.0)
ui_range (0.5, 2.0)
- ui_meta ("unit", "pixel-distance")
property_double (scale1, _("Detail scale, negative values dimnishes signal in detail band, postivie values
increases signal."), -1.6)
description(_("Scaling factor for image features at radius, -1 cancels them out 1.0 edge enhances"))
value_range (-3.0, 100.0)
ui_range (-3.0, 3.0)
-property_double (radius2, _("Edge band"), 4.0)
- description(_("Expressed as standard deviation, in pixels"))
- value_range (0.0, 100.0)
- ui_range (0.5, 20.0)
- ui_meta ("unit", "pixel-distance")
+property_double (bw1, _("Detail bandwidth"), 0.375)
+ description("lower values narrower band, higher values wider band - default value presumed to provide
good band separation.")
+ value_range (0.2, 0.6)
-property_double (scale2, _("Edge scale"), 0.0)
- description(_("Scaling factor for image features at radius, -1 cancels them out 1.0 edge enhances, when
set to 0.0 performance of op is higher."))
- value_range (-3.0, 100.0)
- ui_range (-3.0, 3.0)
+property_boolean (show_mask, _("Show Mask"), FALSE)
#else
#define GEGL_OP_META
-#define GEGL_OP_NAME edges_and_details
-#define GEGL_OP_C_SOURCE edges-and-details.c
+#define GEGL_OP_NAME band_tune
+#define GEGL_OP_C_SOURCE band-tune.c
#include "gegl-op.h"
-#define N_BANDS 2
+#define N_BANDS 1
typedef struct
{
@@ -92,11 +86,14 @@ update_graph (GeglOperation *operation)
case 0:
scale = o->scale1;
radius = o->radius1;
+ bw = 1.0 - o->bw1;
break;
+#if 0
case 1:
scale = o->scale2;
radius = o->radius2;
break;
+#endif
}
if (fabs(scale) > 0.01)
@@ -192,10 +189,10 @@ gegl_op_class_init (GeglOpClass *klass)
operation_class->attach = attach;
gegl_operation_class_set_keys (operation_class,
- "name", "gegl:edges-and-details",
- "title", _("Edges and Details"),
+ "name", "gegl:band-tune",
+ "title", _("Band tune"),
"categories", "enhance:sharpen:denoise",
- "description", _("Two band parametric equalizer, for noise reduction and edge enhancement."),
+ "description", _("Parametric band equalizer"),
NULL);
}
diff --git a/operations/workshop/meson.build b/operations/workshop/meson.build
index 3f1147c9d..116cf4adf 100644
--- a/operations/workshop/meson.build
+++ b/operations/workshop/meson.build
@@ -11,7 +11,7 @@ libraries = [
{ 'name': 'demosaic-bimedian', },
{ 'name': 'demosaic-simple', },
{ 'name': 'ditto', },
- { 'name': 'edges-and-details', },
+ { 'name': 'band-tune', },
{ 'name': 'gcr', },
{ 'name': 'gradient-map', },
{ 'name': 'hstack', },
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]