[mutter/wip/lantw/monitor-transform-Don't-call-abs-on-non-negative-enum: 1/2] tests/monitor-transform: Test only valid enums
- From: Robert Mader <rmader src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [mutter/wip/lantw/monitor-transform-Don't-call-abs-on-non-negative-enum: 1/2] tests/monitor-transform: Test only valid enums
 
- Date: Fri,  8 May 2020 23:03:37 +0000 (UTC)
 
commit e06daa58c335b7bedf232a22dbab2f82ab86532c
Author: Robert Mader <robert mader posteo de>
Date:   Fri May 8 21:13:55 2020 +0200
    tests/monitor-transform: Test only valid enums
    
    This test was introduces assuming we'd do interger math outside
    of `meta-monitor-transform`. We later agreed to not do that and require
    valid enums, but forgot to remove the corresponding test case.
    
    Test the corresponding valid enums instead of negative ones.
    
    See https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1064
    
    https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1234
 src/tests/monitor-transform-tests.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/src/tests/monitor-transform-tests.c b/src/tests/monitor-transform-tests.c
index 91ce985be..fb505d00c 100644
--- a/src/tests/monitor-transform-tests.c
+++ b/src/tests/monitor-transform-tests.c
@@ -62,22 +62,22 @@ test_transform (void)
     },
     {
       .transform = META_MONITOR_TRANSFORM_NORMAL,
-      .other = -META_MONITOR_TRANSFORM_90,
+      .other = META_MONITOR_TRANSFORM_270,
       .expect = META_MONITOR_TRANSFORM_270,
     },
     {
       .transform = META_MONITOR_TRANSFORM_FLIPPED,
-      .other = -META_MONITOR_TRANSFORM_90,
+      .other = META_MONITOR_TRANSFORM_270,
       .expect = META_MONITOR_TRANSFORM_FLIPPED_270,
     },
     {
       .transform = META_MONITOR_TRANSFORM_FLIPPED_180,
-      .other = -META_MONITOR_TRANSFORM_270,
+      .other = META_MONITOR_TRANSFORM_90,
       .expect = META_MONITOR_TRANSFORM_FLIPPED_270,
     },
     {
       .transform = META_MONITOR_TRANSFORM_FLIPPED_180,
-      .other = -META_MONITOR_TRANSFORM_FLIPPED_180,
+      .other = META_MONITOR_TRANSFORM_FLIPPED_180,
       .expect = META_MONITOR_TRANSFORM_NORMAL,
     },
   };
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]