[orca] Handle another case of objects going defunct on us



commit 89014474ea68992d51b2d4001bc50f25f1677441
Author: Joanmarie Diggs <jdiggs igalia com>
Date:   Fri May 8 13:43:11 2020 -0400

    Handle another case of objects going defunct on us

 src/orca/input_event.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
---
diff --git a/src/orca/input_event.py b/src/orca/input_event.py
index db0bc57a6..e4d9485b3 100644
--- a/src/orca/input_event.py
+++ b/src/orca/input_event.py
@@ -411,7 +411,12 @@ class KeyboardEvent(InputEvent):
              + ("                 shouldEcho=%s\n" % self.shouldEcho)
 
     def _shouldObscure(self):
-        if not (self._obj and self._obj.getRole() == pyatspi.ROLE_PASSWORD_TEXT):
+        try:
+            role = self._obj.getRole()
+        except:
+            return False
+
+        if role != pyatspi.ROLE_PASSWORD_TEXT:
             return False
 
         if not self.isPrintableKey():


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]