[gjs/april-maintenance: 11/14] CI: Remove Helgrind suppressions from Valgrind file



commit ded715c53aa4708b2f471384805cf387af544d73
Author: Philip Chimento <philip chimento gmail com>
Date:   Sat May 2 10:37:21 2020 -0700

    CI: Remove Helgrind suppressions from Valgrind file
    
    It's dubious whether Helgrind even works at all with SpiderMonkey, so
    these entries are doing nothing at best.

 installed-tests/extra/gjs.supp | 57 ------------------------------------------
 1 file changed, 57 deletions(-)
---
diff --git a/installed-tests/extra/gjs.supp b/installed-tests/extra/gjs.supp
index 42f4e488..9e580018 100644
--- a/installed-tests/extra/gjs.supp
+++ b/installed-tests/extra/gjs.supp
@@ -127,60 +127,3 @@
    ...
    fun:g_type_register_static
 }
-
-# SpiderMonkey data races
-
-# These are in SpiderMonkey's atomics / thread barrier stuff so presumably
-# locking is working correctly and helgrind just can't detect it?
-
-{
-   mozjs-helgrind-atomic-load-1
-   Helgrind:Race
-   fun:load
-   fun:load
-   fun:operator unsigned int
-}
-
-{
-   mozjs-helgrind-atomic-load-2
-   Helgrind:Race
-   fun:load
-   fun:load
-   fun:operator bool
-}
-
-{
-   mozjs-helgrind-atomic-store
-   Helgrind:Race
-   fun:store
-   fun:store
-   fun:operator=
-}
-
-# Presumably this one is OK since the function is called "thread safe"?!
-{
-   mozjs-helgrind-thread-safe-lookup
-   Helgrind:Race
-   ...
-   fun:lookup
-   fun:readonlyThreadsafeLookup
-   fun:readonlyThreadsafeLookup
-}
-
-{
-   mozjs-helgrind-jit-code
-   Helgrind:Race
-   obj:*
-   ...
-   fun:_ZL13EnterBaselineP9JSContextRN2js3jit12EnterJitDataE
-}
-
-{
-   mozjs-helgrind-probably-jit-code
-   Helgrind:Race
-   obj:*
-   obj:*
-   obj:*
-   obj:*
-   obj:*
-}


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]