[gnome-control-center/wip/oholy/no-users-fixes: 3/4] user-accounts: Show add user button also if no users found



commit 1a38a971ec93bb6a36d57bea963dbf89b02e0877
Author: Ondrej Holy <oholy redhat com>
Date:   Tue May 5 08:52:09 2020 +0200

    user-accounts: Show add user button also if no users found
    
    The add user button is not shown currently if no users are found
    even if the panel is unlocked. Let's show the button to allow
    user creation in this case.
    
    Fixes: https://gitlab.gnome.org/GNOME/gnome-control-center/-/issues/988

 panels/user-accounts/cc-user-panel.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)
---
diff --git a/panels/user-accounts/cc-user-panel.c b/panels/user-accounts/cc-user-panel.c
index 48a7ac897..a2593cceb 100644
--- a/panels/user-accounts/cc-user-panel.c
+++ b/panels/user-accounts/cc-user-panel.c
@@ -1228,16 +1228,9 @@ on_permission_changed (CcUserPanel *self)
         gboolean self_selected;
         ActUser *user;
 
-        user = get_selected_user (self);
-        if (!user) {
-                return;
-        }
-
         is_authorized = g_permission_get_allowed (G_PERMISSION (self->permission));
-        self_selected = act_user_get_uid (user) == geteuid ();
 
         gtk_widget_set_visible (GTK_WIDGET (self->add_user_button), is_authorized);
-
         gtk_widget_set_sensitive (GTK_WIDGET (self->add_user_button), is_authorized);
         if (is_authorized) {
                 setup_tooltip_with_embedded_icon (GTK_WIDGET (self->add_user_button), _("Create a user 
account"), NULL, NULL);
@@ -1257,6 +1250,12 @@ on_permission_changed (CcUserPanel *self)
                 g_object_unref (icon);
         }
 
+        user = get_selected_user (self);
+        if (!user) {
+                return;
+        }
+
+        self_selected = act_user_get_uid (user) == geteuid ();
         gtk_widget_set_sensitive (GTK_WIDGET (self->remove_user_button), is_authorized && !self_selected
                                   && !would_demote_only_admin (user));
         if (is_authorized) {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]