[evolution-rss] rss_ep_need_proxy_http: Fix an 'if' to properly enclose its commands into a block



commit 11a68a6c5ab8deae0e28b06d33385c22e8aab8b2
Author: Milan Crha <mcrha redhat com>
Date:   Tue May 5 09:48:44 2020 +0200

    rss_ep_need_proxy_http: Fix an 'if' to properly enclose its commands into a block
    
    Otherwise the function always returns TRUE, regardless proxy need,
    and eventually leaks memory.

 src/rss-evo-common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/src/rss-evo-common.c b/src/rss-evo-common.c
index 269565b..537ebce 100644
--- a/src/rss-evo-common.c
+++ b/src/rss-evo-common.c
@@ -273,9 +273,10 @@ rss_ep_need_proxy_http (EProxy* proxy, const gchar * host, SoupAddress *addr)
        so_addr = soup_address_get_sockaddr (myaddr, &addr_len);
 #endif
 
-       if (!so_addr)
+       if (!so_addr) {
                g_object_unref (myaddr);
                return TRUE;
+       }
 
        if (so_addr->sa_family == AF_INET) {
                struct in_addr in, *mask, *addr_in;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]