[tracker/wip/carlosg/bindings-in-service: 5/6] libtracker-data: Bail out after error



commit eb51836aab83dcd9d426ed7db6d19a52d621f8d2
Author: Carlos Garnacho <carlosg gnome org>
Date:   Tue May 5 00:38:35 2020 +0200

    libtracker-data: Bail out after error
    
    Otherwise we may potentially overwrite the GError on the next
    iteration, besides it's a broken state already.

 src/libtracker-data/tracker-sparql.c | 2 ++
 1 file changed, 2 insertions(+)
---
diff --git a/src/libtracker-data/tracker-sparql.c b/src/libtracker-data/tracker-sparql.c
index 08d2e6524..e4fc610db 100644
--- a/src/libtracker-data/tracker-sparql.c
+++ b/src/libtracker-data/tracker-sparql.c
@@ -8747,6 +8747,8 @@ prepare_query (TrackerSparql         *sparql,
                                g_set_error (error, TRACKER_SPARQL_ERROR,
                                             TRACKER_SPARQL_ERROR_TYPE,
                                             "Parameter '%s' has no given value", name);
+                               g_object_unref (stmt);
+                               return NULL;
                        }
                } else if (prop_type == TRACKER_PROPERTY_TYPE_BOOLEAN) {
                        if (g_str_equal (binding->literal, "1") ||


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]