[geary/mjog/746-gmail-flag-quote-bug: 5/5] Geary.Imap.Deserializer: Micro-optimise some methods
- From: Michael Gratton <mjog src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geary/mjog/746-gmail-flag-quote-bug: 5/5] Geary.Imap.Deserializer: Micro-optimise some methods
- Date: Sat, 2 May 2020 04:33:50 +0000 (UTC)
commit 542f946753664d47c5e9d78089d2169954ed4dc2
Author: Michael Gratton <mike vee net>
Date: Sat May 2 14:32:18 2020 +1000
Geary.Imap.Deserializer: Micro-optimise some methods
src/engine/imap/transport/imap-deserializer.vala | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
---
diff --git a/src/engine/imap/transport/imap-deserializer.vala
b/src/engine/imap/transport/imap-deserializer.vala
index be69cabb..72e739eb 100644
--- a/src/engine/imap/transport/imap-deserializer.vala
+++ b/src/engine/imap/transport/imap-deserializer.vala
@@ -433,23 +433,28 @@ public class Geary.Imap.Deserializer : BaseObject, Logging.Source {
}
}
- private bool is_current_string_empty() {
- return (current_string == null) || String.is_empty(current_string.str);
+ private inline bool is_current_string_empty() {
+ return (
+ this.current_string == null || this.current_string.len == 0
+ );
}
// Case-insensitive compare
- private bool is_current_string_ci(string cmp) {
- if (current_string == null || String.is_empty(current_string.str))
+ private inline bool is_current_string_ci(string cmp) {
+ if (this.current_string == null ||
+ this.current_string.len != cmp.length) {
return false;
+ }
- return Ascii.stri_equal(current_string.str, cmp);
+ return Ascii.stri_equal(this.current_string.str, cmp);
}
- private void append_to_string(char ch) {
- if (current_string == null)
- current_string = new StringBuilder();
+ private inline void append_to_string(char ch) {
+ if (this.current_string == null) {
+ this.current_string = new StringBuilder();
+ }
- current_string.append_c(ch);
+ this.current_string.append_c(ch);
}
private void save_string_parameter(bool quoted) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]