[vte] widget: Move signal emission to the widget



commit 84258756968c263068db7f7ec4899fcc6feb9380
Author: Christian Persch <chpe src gnome org>
Date:   Fri May 1 23:08:42 2020 +0200

    widget: Move signal emission to the widget

 src/vte.cc    | 6 ------
 src/vtegtk.cc | 4 +++-
 2 files changed, 3 insertions(+), 7 deletions(-)
---
diff --git a/src/vte.cc b/src/vte.cc
index b3271538..25885ed2 100644
--- a/src/vte.cc
+++ b/src/vte.cc
@@ -2050,12 +2050,6 @@ Terminal::set_encoding(char const* charset,
        _vte_debug_print(VTE_DEBUG_IO,
                          "Set terminal encoding to `%s'.\n",
                          encoding());
-       _vte_debug_print(VTE_DEBUG_SIGNALS,
-                         "Emitting `encoding-changed'.\n");
-
-        GObject *object = G_OBJECT(m_terminal);
-       g_signal_emit(object, signals[SIGNAL_ENCODING_CHANGED], 0);
-        g_object_notify_by_pspec(object, pspecs[PROP_ENCODING]);
 
         return true;
 #else
diff --git a/src/vtegtk.cc b/src/vtegtk.cc
index a7b0390a..db334d62 100644
--- a/src/vtegtk.cc
+++ b/src/vtegtk.cc
@@ -4082,8 +4082,10 @@ vte_terminal_set_encoding(VteTerminal *terminal,
         g_object_freeze_notify(object);
 
         auto const rv = IMPL(terminal)->set_encoding(codeset, error);
-        if (rv)
+        if (rv) {
+                g_signal_emit(object, signals[SIGNAL_ENCODING_CHANGED], 0);
                 g_object_notify_by_pspec(object, pspecs[PROP_ENCODING]);
+        }
 
         g_object_thaw_notify(object);
         return rv;


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]